Skip to content

Add virtualization to DomainRankingsTable #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Add virtualization to DomainRankingsTable #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f60b4c8
Initial plan
Copilot Feb 21, 2026
5beaa0a
Add virtualization for the ranking list using @tanstack/react-virtual
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 75 additions & 43 deletions components/DomainRankingsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
"use client"

import { useRef } from "react"
import Link from "next/link"
import { Trophy, Medal, Award, ExternalLink } from "lucide-react"
import { Card, CardContent } from "@/components/ui/card"
import { ScoreGauge } from "@/components/ScoreGauge"
import { useVirtualizer } from "@tanstack/react-virtual"

interface DomainRanking {
id: string
Expand Down Expand Up @@ -58,6 +60,15 @@ export function DomainRankingsTable({
}: {
rankings: DomainRanking[]
}) {
const parentRef = useRef<HTMLDivElement>(null)

const rowVirtualizer = useVirtualizer({
count: rankings.length,
getScrollElement: () => parentRef.current,
estimateSize: () => 56,
overscan: 5,
})

if (rankings.length === 0) {
return (
<Card className="border-border/50 bg-card/50">
Expand Down Expand Up @@ -120,54 +131,75 @@ export function DomainRankingsTable({
<span className="w-20 text-center">Score</span>
<span className="w-28 text-right">Last tested</span>
</div>
</div>

{rankings.map((entry, i) => {
const rank = i + 1
return (
<Link
key={entry.id}
href={`/${entry.id}`}
className="flex items-center gap-4 px-5 py-3.5 transition-colors hover:bg-muted/20 group"
>
{/* Rank */}
<div className="w-10 flex justify-center">
<RankBadge rank={rank} />
</div>
{/* Virtualized list */}
<div
ref={parentRef}
className="overflow-y-auto max-h-[600px]"
>
<div
style={{ height: `${rowVirtualizer.getTotalSize()}px`, position: "relative" }}
>
{rowVirtualizer.getVirtualItems().map((virtualRow) => {
const entry = rankings[virtualRow.index]
const rank = virtualRow.index + 1
return (
<div
key={entry.id}
style={{
position: "absolute",
top: 0,
left: 0,
width: "100%",
transform: `translateY(${virtualRow.start}px)`,
}}
>
<Link
href={`/${entry.id}`}
className={`flex items-center gap-4 px-5 py-3.5 transition-colors hover:bg-muted/20 group border-t ${virtualRow.index === 0 ? "border-transparent" : "border-border/40"}`}
>
{/* Rank */}
<div className="w-10 flex justify-center">
<RankBadge rank={rank} />
</div>

{/* Domain */}
<div className="flex-1 min-w-0">
<p className="text-sm font-medium truncate group-hover:underline">
{entry.domain}
</p>
<p className="text-xs text-muted-foreground truncate sm:hidden">
{formatDate(entry.created_at)}
</p>
</div>
{/* Domain */}
<div className="flex-1 min-w-0">
<p className="text-sm font-medium truncate group-hover:underline">
{entry.domain}
</p>
<p className="text-xs text-muted-foreground truncate sm:hidden">
{formatDate(entry.created_at)}
</p>
</div>

{/* Score */}
<div className="w-20 flex justify-center">
<span
className={`text-sm font-bold tabular-nums ${getScoreColor(
entry.overall_score
)}`}
>
{entry.overall_score}
<span className="text-xs font-normal text-muted-foreground">
/100
</span>
</span>
</div>
{/* Score */}
<div className="w-20 flex justify-center">
<span
className={`text-sm font-bold tabular-nums ${getScoreColor(
entry.overall_score
)}`}
>
{entry.overall_score}
<span className="text-xs font-normal text-muted-foreground">
/100
</span>
</span>
</div>

{/* Date */}
<div className="hidden w-28 text-right sm:flex items-center justify-end gap-1.5">
<span className="text-xs text-muted-foreground">
{formatDate(entry.created_at)}
</span>
<ExternalLink className="size-3 text-muted-foreground/50" />
{/* Date */}
<div className="hidden w-28 text-right sm:flex items-center justify-end gap-1.5">
<span className="text-xs text-muted-foreground">
{formatDate(entry.created_at)}
</span>
<ExternalLink className="size-3 text-muted-foreground/50" />
</div>
</Link>
</div>
</Link>
)
})}
)
})}
</div>
</div>
</Card>
</div>
Expand Down
Loading
Loading