Match sidebar title search on subdirectories#250
Conversation
…hints When called with unrecognized params (e.g. new-tab with url), the MCP tool now returns an error listing valid parameters. A specific hint suggests open-browser when url is passed to new-tab. Help text updated to clarify the distinction between new-tab and open-browser, with a new playbook for opening URLs.
…ch-subdir-tabs # Conflicts: # test/unit/server/mcp/freshell-tool.test.ts
Restore agent-chat.spec.ts, update-flow.test.ts, and codex-session-flow.test.ts to their main branch versions. These test rewrites are unrelated to the sidebar search feature and have been separated into PR #249. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b408c67ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| dispatch(commitSessionWindowVisibleRefresh({ | ||
| ...payload, | ||
| preserveLoading: preserveLoadingState, | ||
| })) |
There was a problem hiding this comment.
refreshVisibleSessionWindowSilently captures preserveLoadingState once and reuses it for every later commit, so a refresh that started with preserveLoadingState = false can still commit after a new fetchSessionWindow has begun. In that race, canCommit() still succeeds (it only checks visible identity), and this commit clears loading/loadingKind even though the replacement request is still in flight; that hides the active search state and can re-enable pagination/backfill paths that may dispatch append and abort the active search through abortSurface.
Useful? React with 👍 / 👎.
1 participant
Summary
Replaces #240 (which had its base branch set to
fix/mcp-param-validationinstead ofmain).Unrelated test rewrites were separated into #249.
Test Plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com