Proposed fix to file upload race condition#2436
Open
chong-he wants to merge 2 commits intodappnode:developfrom
Open
Proposed fix to file upload race condition#2436chong-he wants to merge 2 commits intodappnode:developfrom
chong-he wants to merge 2 commits intodappnode:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a race condition for a fresh install of a DAppNode package, where if there is a file upload involved, the package will crash on the first run, as described in the issue below:
dappnode/DAppNodePackage-anchor-generic#6
Approach
Removed the start/stop logic. docker cp works on containers in any state (created, stopped, or running). The container no longer gets prematurely started before the file is ready.
Test instructions
Tested on both Anchor and SSV packages, the crash-on-first-run when
import operatormode is selected is no longer there, i.e., it successfully run on fresh setup.Disclaimer: the solution is 100% generated by Claude code, I only tweak the comments a bit