Skip to content

Proposed fix to file upload race condition #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chong-he wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Proposed fix to file upload race condition #2436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652143e
try to fix file upload race condition
chong-he May 6, 2026
564816c
revise comments
chong-he May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions packages/dockerApi/src/api/copyFileTo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import fs from "fs";
import dataUriToBuffer from "data-uri-to-buffer";
import { params } from "@dappnode/params";
import { shell } from "@dappnode/utils";
import { dockerContainerInspect, dockerContainerStart, dockerContainerStop } from "./container.js";
import { logs } from "@dappnode/logger";

const tempTransferDir = params.TEMP_TRANSFER_DIR;

Expand Down Expand Up @@ -66,32 +64,13 @@ export async function copyFileToDockerContainer({
// Remove existing file if it exists
if (fs.existsSync(fromPath)) fs.rmSync(fromPath, { recursive: true, force: true });

/**
* Convert dataUri to local file
*
* In this conversion direction MIME types don't matter
* The extension is what decides the type and it's the user's
* responsability to specify it correctly on the UI. The code will
* not cause problems if the types are not setup corretly
*/
dataUriToFile(dataUri, fromPath);

// Container needs to be running to copy files
const containerInspect = await dockerContainerInspect(containerName);
const isInitiallyRunning = containerInspect.State.Running;

if (!isInitiallyRunning) await dockerContainerStart(containerName);

// Copy file from local file system to container
await dockerCopyFileTo(containerName, fromPath, toPath);

// Clean intermediate file
if (fs.existsSync(fromPath)) fs.rmSync(fromPath, { recursive: true, force: true });

if (!isInitiallyRunning)
dockerContainerStop(containerName).catch((err) =>
logs.error(`Error stopping container ${containerName} after copying a file to it: ${err}`)
);
}

function dockerCopyFileTo(id: string, fromPath: string, toPath: string): Promise<string> {
Expand Down