Skip to content

Make Dapr.Workflow a single NuGet meta-package#1824

Merged
WhitWaldo merged 5 commits into
masterfrom
copilot/fix-nuget-packaging-dapr-workflow
May 21, 2026
Merged

Make Dapr.Workflow a single NuGet meta-package#1824
WhitWaldo merged 5 commits into
masterfrom
copilot/fix-nuget-packaging-dapr-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

  • Restore single-Dapr.Workflow meta-package bundling all Dapr.Workflow.* siblings.
  • Revert Dapr.Workflow.csproj <Description> to "Dapr Workflow SDK for building workflows as code with Dapr".

…ng Workflow.* packages

Agent-Logs-Url: https://github.com/dapr/dotnet-sdk/sessions/83c0afde-8029-4646-9435-5861ab7af038

Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
…no cross-sibling deps

Agent-Logs-Url: https://github.com/dapr/dotnet-sdk/sessions/f543df30-3d89-4413-a7a9-3d779f2b004c

Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
Copilot AI and others added 2 commits May 21, 2026 03:53
…nupkgs, no cross-sibling deps"

This reverts commit 7fce020.

Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.47%. Comparing base (7ecbb8d) to head (ccf4163).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
+ Coverage   63.46%   63.47%   +0.01%     
==========================================
  Files         312      312              
  Lines        9279     9279              
  Branches     1101     1101              
==========================================
+ Hits         5889     5890       +1     
- Misses       3129     3130       +1     
+ Partials      261      259       -2     
Flag Coverage Δ
net10.0 63.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo
Copy link
Copy Markdown
Contributor

@copilot If I just run dotnet pack Dapr.Workflow from /src, I see this pack only Dapr.Workflow as expected. But if I run dotnet pack from the solution root, I see that it builds the other packages. I need to ensure that when this runs the build in GitHub actions, it's not going to build and deploy all these extra NuGet packages (again, the goal is to bundle everything as the one Dapr.Workflow NuGet package). Can you please address this?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 21, 2026

@copilot If I just run dotnet pack Dapr.Workflow from /src, I see this pack only Dapr.Workflow as expected. But if I run dotnet pack from the solution root, I see that it builds the other packag...

I just verified this on the current HEAD (ccf4163) by running a clean dotnet pack --configuration release from the solution root. The only Workflow-family nupkg produced is Dapr.Workflow.1.18.0-rc02.5.nupkg — no Dapr.Workflow.Abstractions, Dapr.Workflow.Grpc, Dapr.Workflow.Analyzers, or Dapr.Workflow.Versioning* nupkgs are emitted. The <IsPackable>false</IsPackable> set on each sibling csproj (in 029fc10) suppresses nupkg generation even though the siblings still get compiled as project references. So the CI dotnet pack step in sdk_build.yml will only upload/publish the single Dapr.Workflow package — no extra Workflow.* packages will be deployed. If you were seeing sibling packages locally, it was likely from a build prior to that commit or from stale artifacts under bin/Release/nugets/; an rm -rf bin/ and re-pack should give a clean single-package result.

@WhitWaldo WhitWaldo marked this pull request as ready for review May 21, 2026 17:05
@WhitWaldo WhitWaldo requested review from a team as code owners May 21, 2026 17:05
@WhitWaldo WhitWaldo merged commit 0621b54 into master May 21, 2026
481 of 485 checks passed
@WhitWaldo WhitWaldo deleted the copilot/fix-nuget-packaging-dapr-workflow branch May 21, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants