Fix Peekaboo MacInCloud capture proof#105
Conversation
📋 PR Overview
🔬 Coverage
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff87afbed2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
ff87afb to
9311b5a
Compare
9311b5a to
6277bda
Compare
nixmac Peekaboo E2E: ❌ FAIL
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98d8ea5649
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f4af8eefd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
8fb3f16 to
eea0eb6
Compare
Summary
This follow-up fixes the MacInCloud Peekaboo report failure seen after PR #101 merged, where the app DOM mounted but screenshots showed black/blank central content.
What changed:
backdrop-filter/-webkit-backdrop-filterunderhtml[data-nixmac-e2e-capture="solid"].nixmac:app-mounted+ 2 RAFs so future MacInCloud capture failures show whether the CSS, root, body, and app shell actually painted.NIXMAC_E2E_PRELOAD_NATIVE_CAPTURE,NIXMAC_E2E_PAGE_LOAD_NATIVE_CAPTURE) so the default Scott-driver path relies on shell readiness plus on-demand capture.Small develop-base cleanup included because the rebased PR merge ref failed local/CI gates before this PR could be honestly verified:
search_packages.rs.directory-picker.test.tsxmock typing/duplicate setup from the earlier branch history, plus the current merge-ref duplicateSetDirResultimport. PR fix(test): dir picker test reconsile dopple fix merge #115 also touches this test file, but the line ranges are disjoint; this PR keeps the change minimal so Fix Peekaboo MacInCloud capture proof #105 can stay independently green.Plus/DropdownMenu*imports inprompt-input.tsxthat are only referenced inside JSX comments.effect/Schema.BooleanFromStringparser inenv.tswith explicit env parsing forVITE_SERVER_URLand optional booleanNIX_INSTALLED_OVERRIDE. The boolean parser accepts common truthy/falsy strings (true/false,1/0,yes/no,on/off); the only consumer checks strictly fortrue.How to test
Run locally:
Expected CI validation:
Verification performed
Latest local verification on rebased commit
eea0eb61:$claude-reviewproposal review completed; blocking PR fix(test): dir picker test reconsile dopple fix merge #115 overlap feedback was incorporated.node tools/computer-use-e2e/peekaboo-workflow-contract-self-test.mjspassed.bash tests/e2e/lib/peekaboo.test.shpassed.node tools/computer-use-e2e/run-local.mjs self-testpassed.cargo clippy --manifest-path apps/native/src-tauri/Cargo.toml -- -D warningspassed.bun install --frozen-lockfilepassed.(cd apps/native && bunx tsc --noEmit)passed.bun -F native test:unit src/components/widget/controls/directory-picker.test.tsxpassed, with existing Reactact(...)warnings.bun -F native buildpassed.git diff --checkpassed.$claude-reviewimplementation review completed with zero blocking issues and approved commit/push/rerun.Known local tooling note:
bun -F native lintcurrently fails before source analysis because.oxlintrc.jsonreferences eslint plugin rule groups not recognized by the installed oxlint. This patch does not touch oxlint config.Docs
This is an E2E capture/reporting stabilization change. It does not change user-facing nixmac behavior or public docs semantics.