Skip to content

fix(test): dir picker test reconsile dopple fix merge#115

Merged
Cas Linden (CasLinden) merged 3 commits into
developfrom
cas/dir-picker-test
May 12, 2026
Merged

fix(test): dir picker test reconsile dopple fix merge#115
Cas Linden (CasLinden) merged 3 commits into
developfrom
cas/dir-picker-test

Conversation

@CasLinden
Copy link
Copy Markdown
Contributor

Summary

Reconsile two separate test fixes for dir picker that both got adopted in conflict resolution

Test Plan

cd apps/native && npx vitest run --project=unit src/components/widget/controls/directory-picker.test.tsx

Docs

  • No docs update needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Warnings
⚠️ Please assign this PR to someone (usually yourself).

📋 PR Overview

Lines changed 98 (+2 / -96)
Files 0 added, 1 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 17.3% 17.3% 27.8% 52.9%

Generated by 🚫 dangerJS against a3b8ca4

@fkb032
Copy link
Copy Markdown
Contributor

FYI for coordination: PR #105 had to rebase onto current develop and make its merge ref independently green, so it includes the minimal duplicate SetDirResult import removal in directory-picker.test.tsx. I checked your PR #115 diff and the line ranges look disjoint from #105's one-line import cleanup; PR #105 is not trying to absorb the broader test cleanup here.

@CasLinden
Copy link
Copy Markdown
Contributor Author

Merged develop preferring my version as the fix on there wasn't fixing.

@github-actions
Copy link
Copy Markdown
Contributor

nixmac Peekaboo E2E: ❌ FAIL

Merged via the queue into develop with commit 9963349 May 12, 2026
12 of 14 checks passed
@CasLinden Cas Linden (CasLinden) deleted the cas/dir-picker-test branch May 12, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants