fix(evolution): cancel is not an error#120
Open
Cas Linden (CasLinden) wants to merge 2 commits into
Open
Conversation
Contributor
📋 PR Overview
|
Contributor
nixmac Peekaboo E2E: ❌ FAIL
|
| const msg = (e as Error)?.message || String(e); | ||
| // User-initiated cancellation isn't an error — backup still ran, so refresh | ||
| // the change map but skip the red banner. | ||
| const isCancelled = msg.toLowerCase().includes("cancelled by user"); |
Contributor
There was a problem hiding this comment.
Suggest this should be a const. (Looking at the related Rust code, it definitely should be there, too.)
Scott McMaster (scottmcmaster)
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivial
Summary
Stop setting cancellation as an error in the frontend, while keeping it in the backend so backup mechanism triggers.
Test Plan
cancel an evolution (given that the server is up / authorization works)
Docs