Skip to content

fix(evolution): cancel is not an error #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cas Linden (CasLinden) wants to merge 2 commits into from
+15 −9
Open

fix(evolution): cancel is not an error #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33735dc
fix(evolution): cancel is not an error
CasLinden May 8, 2026
0a3e7a4
Merge branch 'develop' into cas/cancel-no-error
CasLinden May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions apps/native/src/hooks/use-evolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,22 @@ const handleEvolve = async () => {
store.setEvolvePrompt("");
} catch (e: unknown) {
const msg = (e as Error)?.message || String(e);
// User-initiated cancellation isn't an error — backup still ran, so refresh
// the change map but skip the red banner.
const isCancelled = msg.toLowerCase().includes("cancelled by user");
Copy link
Copy Markdown
Contributor

@scottmcmaster Scott McMaster (scottmcmaster) May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest this should be a const. (Looking at the related Rust code, it definitely should be there, too.)


console.error("[useEvolve] Evolution failed:", {
error: e,
message: msg,
stack: (e as Error)?.stack,
timestamp: new Date().toISOString(),
});

useWidgetStore.getState().setError(msg);
useWidgetStore.getState().appendLog(`✗ Error: ${msg}\n`);
if (isCancelled) {
useWidgetStore.getState().appendLog("✗ Evolution cancelled\n");
} else {
console.error("[useEvolve] Evolution failed:", {
error: e,
message: msg,
stack: (e as Error)?.stack,
timestamp: new Date().toISOString(),
});
useWidgetStore.getState().setError(msg);
useWidgetStore.getState().appendLog(`✗ Error: ${msg}\n`);
}
await findChangeMap();
} finally {
useWidgetStore.getState().setGenerating(false);
Expand Down
Loading