Upgrade to Pydantic v2 with minimal code changes#888
Open
jdoiro3 wants to merge 1 commit intodatabrickslabs:mainfrom
Open
Upgrade to Pydantic v2 with minimal code changes#888jdoiro3 wants to merge 1 commit intodatabrickslabs:mainfrom
jdoiro3 wants to merge 1 commit intodatabrickslabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I know this project isn't maintained anymore and understand this probably will never merge.
Proposed changes
Bump Pydantic to >=2.0.0 since it ships with v1. All you have to do is change
from pydantictofrom pedantic.v1.Types of changes
These changes should not have any impact on
dbxand is more about letting users ofdbxto migrate frompydanticv1 to v2.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...