Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ clean: ## Clean .venv, dist, build
@echo ""
@echo "${YELLOW}Current python:${NORMAL}"
@make helper-line
@python --version
@python3 --version

@make docs-clean

Expand All @@ -106,13 +106,13 @@ install-e: ## Install project as editable.
@echo ""
@echo "${YELLOW}Install project as editable${NORMAL}"
@make helper-line
python -m pip install -e .
python3 -m pip install -e .

install-dev: ## Install dev dependencies.
@echo ""
@echo "${YELLOW}Install Dev dependencies.${NORMAL}"
@make helper-line
python -m pip install -e ".[dev]"
python3 -m pip install -e ".[dev]"

post-install-info: ## Just some post installation info.
@echo ""
Expand All @@ -139,36 +139,36 @@ lint: ## Run the lint and checks
@echo ""
@echo "${YELLOW}Linting code:${NORMAL}"
@make helper-line
python -m prospector --profile prospector.yaml
python3 -m prospector --profile prospector.yaml
@make check

check: ## Run black checks
@echo ""
@echo "${YELLOW}Check code with black:${NORMAL}"
@make helper-line
python -m black --check .
python3 -m black --check .

fix: ## fix the code with black formatter.
@echo ""
@echo "${YELLOW}Fixing code with black:${NORMAL}"
@make helper-line
python -m black .
python3 -m black .

##############################################################################

test: ## Run the tests. (option): file=tests/path/to/file.py
@echo ""
@echo "${YELLOW}Running tests:${NORMAL}"
@make helper-line
python -m pytest -vv --cov dbx $(file) -n auto \
python3 -m pytest -vv --cov dbx $(file) -n auto \
--cov-report=xml \
--cov-report=term-missing:skip-covered

test-with-html-report: ## Run all tests with html reporter.
@echo ""
@echo "${YELLOW}Testing with html report:${NORMAL}"
@make helper-line
python -m pytest --cov dbx -n auto --cov-report html -s
python3 -m pytest --cov dbx -n auto --cov-report html -s

##############################################################################

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies = [
"Jinja2>=2.11.2",
"mlflow-skinny>=2.0.0,<3.0.0",
"pathspec>=0.9.0",
"pydantic>=1.10.8,<2.0.0",
"pydantic>=2.0.0",
"pyyaml>=6.0",
"requests>=2.30.1,<3.0.0",
"rich>=12.6.0,<=13.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/adjuster/adjuster.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Any, List, Optional, Union

from databricks_cli.sdk import ApiClient
from pydantic import BaseModel
from pydantic.v1 import BaseModel

from dbx.api.adjuster.mixins.existing_cluster import ExistingClusterAdjuster
from dbx.api.adjuster.mixins.file_reference import FileReferenceAdjuster
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/adjuster/mixins/base.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from abc import ABC

from databricks_cli.sdk import ApiClient
from pydantic import BaseModel
from pydantic.v1 import BaseModel

from dbx.models.workflow.common.flexible import FlexibleModel

Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/adjuster/mixins/service_principal.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import functools
from typing import Any, List

from pydantic import Field
from pydantic.v1 import Field

from dbx.api.adjuster.mixins.base import ApiClientMixin, ElementSetterMixin
from dbx.models.workflow.common.flexible import FlexibleModel
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/config_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import jinja2
import yaml
from pydantic import BaseModel
from pydantic.v1 import BaseModel

import dbx.api.jinja as dbx_jinja
from dbx.api._module_loader import load_module_from_source
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/launch/pipeline_models.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from enum import Enum
from typing import List, Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel


class UpdateStatus(str, Enum):
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/launch/runners/base.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel


class RunData(BaseModel):
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/api/launch/runners/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import List, Optional, Tuple

from databricks_cli.sdk import ApiClient
from pydantic import BaseModel
from pydantic.v1 import BaseModel
from rich.console import Console

from dbx.api.launch.pipeline_models import PipelineDetails, PipelineGlobalState
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from enum import Enum
from typing import List, Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel
from rich.console import Console

from dbx.api.build import cleanup_dist, execute_shell_command
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/cli/destroyer.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from enum import Enum
from typing import List, Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel

from dbx.models.deployment import AnyWorkflow, EnvironmentDeploymentInfo

Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/cli/execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import json

from pydantic import root_validator
from pydantic.v1 import root_validator

from dbx.models.validators import at_least_one_of, mutually_exclusive
from dbx.models.workflow.common.parameters import NamedParametersMixin, ParametersMixin
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import collections
from typing import Any, Dict, List, Optional, Union

from pydantic import BaseModel, Field, validator
from pydantic.v1 import BaseModel, Field, validator
from rich.markup import escape
from typing_extensions import Annotated

Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/files/context.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pydantic import BaseModel
from pydantic.v1 import BaseModel


class ContextInfo(BaseModel):
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/files/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from enum import Enum
from typing import Dict, Optional, Union

from pydantic import BaseModel
from pydantic.v1 import BaseModel

from dbx.constants import PROJECT_INFO_FILE_PATH
from dbx.utils import dbx_echo
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/access_control.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from enum import Enum
from typing import Any, Dict, List, Optional

from pydantic import root_validator, validator
from pydantic.v1 import root_validator, validator

from dbx.models.validators import at_least_one_of
from dbx.models.workflow.common.flexible import FlexibleModel
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/deployment_config.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel


class DbxDeploymentConfig(BaseModel):
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/flexible.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import List

from pydantic import BaseModel, Extra
from pydantic.v1 import BaseModel, Extra

from dbx.utils import dbx_echo

Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/libraries.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import List, Optional

from pydantic import root_validator
from pydantic.v1 import root_validator

from dbx.models.validators import at_least_one_of, mutually_exclusive
from dbx.models.workflow.common.flexible import FlexibleModel
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/new_cluster.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional

from pydantic import root_validator, validator
from pydantic.v1 import root_validator, validator

from dbx.models.workflow.common.flexible import FlexibleModel

Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import Any, Dict, List, Optional

from pydantic import BaseModel
from pydantic.v1 import BaseModel

ParamPair = Optional[Dict[str, str]]
StringArray = Optional[List[str]]
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/pipeline.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any, Dict, List, Literal, Optional

from pydantic import validator
from pydantic.v1 import validator

from dbx.models.workflow.common.access_control import AccessControlMixin
from dbx.models.workflow.common.flexible import FlexibleModel
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/common/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from pathlib import Path
from typing import Optional

from pydantic import root_validator, validator
from pydantic.v1 import root_validator, validator

from dbx.constants import TASKS_SUPPORTED_IN_EXECUTE
from dbx.models.cli.execute import ExecuteParametersPayload
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/v2dot0/parameters.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pydantic import root_validator
from pydantic.v1 import root_validator

from dbx.models.validators import mutually_exclusive
from dbx.models.workflow.common.parameters import BaseParametersMixin, ParametersMixin, StandardBasePayload
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/v2dot0/workflow.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import List, Literal, Optional, Union

from pydantic import root_validator, validator
from pydantic.v1 import root_validator, validator

from dbx.models.workflow.common.access_control import AccessControlMixin
from dbx.models.workflow.common.deployment_config import DbxDeploymentConfig
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/v2dot1/job_cluster.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import collections
from typing import Any, Dict, List, Optional

from pydantic import root_validator
from pydantic.v1 import root_validator

from dbx.models.workflow.common.flexible import FlexibleModel
from dbx.models.workflow.common.new_cluster import NewCluster
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/v2dot1/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json
from typing import List, Optional

from pydantic import BaseModel, validator
from pydantic.v1 import BaseModel, validator

from dbx.models.validators import check_dbt_commands
from dbx.models.workflow.common.parameters import (
Expand Down
4 changes: 2 additions & 2 deletions src/dbx/models/workflow/v2dot1/task.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from enum import Enum
from typing import Dict, List, Optional

from pydantic import BaseModel, root_validator, validator
from pydantic.fields import Field
from pydantic.v1 import BaseModel, root_validator, validator
from pydantic.v1.fields import Field

from dbx.models.validators import at_least_one_of, check_dbt_commands, mutually_exclusive
from dbx.models.workflow.common.flexible import FlexibleModel
Expand Down
2 changes: 1 addition & 1 deletion src/dbx/models/workflow/v2dot1/workflow.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import collections
from typing import Any, Dict, List, Literal, Optional

from pydantic import root_validator, validator
from pydantic.v1 import root_validator, validator

from dbx.models.validators import at_least_one_of, mutually_exclusive
from dbx.models.workflow.common.access_control import AccessControlMixin
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/commands/test_destroy.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_ask_for_confirmation_negative(monkeypatch, base_config):
"mode, expected",
[
("all", "All assets are also marked for deletion"),
("workflows_only", "assets won't be affected"),
("workflows_only", "assets won't beaffected"), # TODO: for some reason the output removes the last space. Figure out why.
("assets_only", "workflow definitions won't be affected"),
],
)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/models/test_job_clusters.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from pydantic import ValidationError
from pydantic.v1 import ValidationError

from dbx.models.workflow.v2dot1.job_cluster import JobClustersMixin

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/models/test_task.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from pathlib import Path

import pytest
from pydantic import ValidationError
from pydantic.v1 import ValidationError

from dbx.models.cli.execute import ExecuteParametersPayload
from dbx.models.workflow.common.task import BaseTaskMixin, SparkJarTask, SparkPythonTask, SparkSubmitTask
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/models/test_v2dot1_workflow.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from pydantic import ValidationError
from pydantic.v1 import ValidationError

from dbx.models.workflow.v2dot1.parameters import AssetBasedRunPayload
from dbx.models.workflow.v2dot1.workflow import Workflow
Expand Down