Skip to content

Polish navigation for native sidebar and detail push - #12

Draft
davidhoang wants to merge 1 commit into
mainfrom
cursor/navigation-polish
Draft

Polish navigation for native sidebar and detail push#12
davidhoang wants to merge 1 commit into
mainfrom
cursor/navigation-polish

Conversation

@davidhoang

Copy link
Copy Markdown
Owner

Summary

  • Remove programmatic sidebar auto-collapse so NavigationSplitView handles expand/collapse natively
  • Add a left sidebar toolbar toggle (sidebar.left) matching the inspector control
  • Push image detail via NavigationStack + navigationDestination instead of a ZStack opacity overlay
  • Persist inspector visibility with @AppStorage and remove custom inspector chrome
  • Delete unused WidthReader and update navigation rules in design.md

Test plan

  • Resize the window and confirm the left sidebar collapses/expands smoothly via the divider and ⌃⌘S
  • Toggle left sidebar and right inspector from the toolbar
  • Double-click an image and confirm detail pushes with native back navigation
  • Press Escape or click back to return to the library grid
  • Confirm inspector visibility persists across detail enter/exit and app relaunch
  • Verify VoiceOver labels on sidebar.toggle and inspector.toggle

Made with Cursor

Remove programmatic sidebar auto-collapse, add a sidebar toggle, push detail via NavigationStack, persist inspector visibility, and drop custom inspector chrome.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant