Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions main/src/ipc/daemonRegistryBindings.test.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,36 @@
import { describe, expect, it, vi } from 'vitest';
import { PaneCommandRegistry } from '../daemon/commandRegistry';
import { registerFileHandlers } from './file';
import { registerPanelHandlers } from './panels';
import { registerProjectHandlers } from './project';
import { registerPromptHandlers } from './prompt';
import { registerScriptHandlers } from './script';
import type { AppServices } from './types';

vi.mock('../index', () => ({
webviewContextMap: new Map<number, { panelId: string; sessionId: string }>(),
}));

vi.mock('../services/panelManager', () => ({
panelManager: {},
}));

vi.mock('../services/terminalPanelManager', () => ({
terminalPanelManager: {},
}));

vi.mock('../services/database', () => ({
databaseService: {},
}));

vi.mock('../services/panels/logPanel/logsManager', () => ({
logsManager: {},
}));

vi.mock('../services/scriptExecutionTracker', () => ({
scriptExecutionTracker: {},
}));

const PROJECT_CHANNELS = [
'projects:get-all',
'projects:get-active',
Expand Down Expand Up @@ -57,6 +79,49 @@ const FILE_CHANNELS = [
'file:resolveAbsolutePath',
] as const;

const PANEL_CHANNELS = [
'panels:create',
'panels:delete',
'panels:update',
'panels:list',
'panels:set-active',
'panels:getActive',
'panels:initialize',
'panels:checkInitialized',
'panels:emitEvent',
'panels:resize-terminal',
'panels:send-terminal-input',
'panels:shouldAutoCreate',
'terminal:input',
'terminal:resize',
'terminal:getState',
'terminal:saveState',
'terminal:saveSnapshot',
'terminal:clearScrollback',
'terminal:setVisibility',
'terminal:ack',
'terminal:resetFlowControl',
'terminal:getAltScreenState',
'terminal:getScrollbackClean',
'terminal:paste-image',
'terminal:save-scrollback',
'terminal:paste-file',
] as const;

const SCRIPT_CHANNELS = [
'sessions:has-run-script',
'sessions:get-running-session',
'sessions:run-script',
'sessions:stop-script',
'sessions:run-terminal-command',
'sessions:send-terminal-input',
'sessions:pre-create-terminal',
'sessions:resize-terminal',
'logs:runScript',
'logs:stopScript',
'logs:isRunning',
] as const;

interface IpcMainStub {
boundChannels: string[];
handle(channel: string, listener: (_event: unknown, ...args: unknown[]) => unknown): void;
Expand Down Expand Up @@ -118,4 +183,35 @@ describe('daemon registry IPC bindings', () => {
);
expect(registry.has('file:showInFolder')).toBe(false);
});

it('keeps browser and clipboard panel adapters outside the daemon registry surface', () => {
const registry = new PaneCommandRegistry();
const ipcMain = createIpcMainStub();

registerPanelHandlers(ipcMain, createServicesStub(), registry);

expect(registry.listChannels()).toEqual([...PANEL_CHANNELS].sort());
expect(ipcMain.boundChannels).toContain('terminal:clipboard-paste-image');
expect(ipcMain.boundChannels).toContain('browser-panel:register-webview');
expect(
ipcMain.boundChannels.filter(
channel => channel !== 'terminal:clipboard-paste-image' && channel !== 'browser-panel:register-webview',
).sort(),
).toEqual([...PANEL_CHANNELS].sort());
expect(registry.has('terminal:clipboard-paste-image')).toBe(false);
});

it('keeps local IDE launching outside the daemon registry surface', () => {
const registry = new PaneCommandRegistry();
const ipcMain = createIpcMainStub();

registerScriptHandlers(ipcMain, createServicesStub(), registry);

expect(registry.listChannels()).toEqual([...SCRIPT_CHANNELS].sort());
expect(ipcMain.boundChannels).toContain('sessions:open-ide');
expect(ipcMain.boundChannels.filter(channel => channel !== 'sessions:open-ide').sort()).toEqual(
[...SCRIPT_CHANNELS].sort(),
);
expect(registry.has('sessions:open-ide')).toBe(false);
});
});
4 changes: 2 additions & 2 deletions main/src/ipc/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ export function registerIpcHandlers(services: AppServices): PaneCommandRegistry
registerConfigHandlers(ipcMain, services);
registerDialogHandlers(ipcMain, services);
registerGitHandlers(ipcMain, services);
registerScriptHandlers(ipcMain, services);
registerScriptHandlers(ipcMain, services, commandRegistry);
registerPromptHandlers(ipcMain, services, commandRegistry);
registerFileHandlers(ipcMain, services, commandRegistry);
registerFolderHandlers(ipcMain, services, commandRegistry);
registerUIStateHandlers(services);
registerDashboardHandlers(ipcMain, services);
setupLogHandlers(ipcMain, services.sessionManager, commandRegistry);
registerPanelHandlers(ipcMain, services);
registerPanelHandlers(ipcMain, services, commandRegistry);
registerEditorPanelHandlers(ipcMain, services);
registerNimbalystHandlers(ipcMain, services);
registerSpotlightHandlers(ipcMain, services);
Expand Down
Loading