feat(foreman): integrate + reconcile AgenticTask kinds + slice payload#1037
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
7 tasks
Add the integrate and reconcile AgenticTaskKind values (enum widened on both AgenticTask.spec.kind and Workload pipeline steps) and the payload fields the sliced-workload pipeline needs: Slices ([]SliceRef of name/branch/files), Contract, and SharedIdentifiers ([]SharedIdentifier of id/definedBy/ referencedBy). integrate reads slices[].branch + baseBranch; reconcile reads sharedIdentifiers + slices[].files + contract. Base and integration branch reuse the existing baseBranch/branch fields. API surface only: no executor handling yet (a follow-up wires the two kinds to the slicer libraries). Regenerated deepcopy + CRD manifests + chart CRDs; the AgenticTask webhook validates only agentRef, so no webhook change. Part of defilantech#1033 Signed-off-by: Christopher Maher <chris@mahercode.io>
Defilan
force-pushed
the
feat/slicer-task-kinds
branch
from
762b51d to
3b6f311
Compare
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Task 3 of the Sliced Workloads epic (#1033): the API surface for the two new task kinds.
integrateandreconcileto theAgenticTaskKindenum (widened on bothAgenticTask.spec.kindandWorkloadpipeline steps).Slices []SliceRef— each{name, branch, files}.integrateunionsslices[].branch;reconcilechecks pins againstslices[].files.Contract string— the plan's prose contract, handed to areconciletask's LLM sweep. Reconcile only.SharedIdentifiers []SharedIdentifier— each{id, definedBy, referencedBy}, the pins areconciletask verifies. Reconcile only.baseBranch/branchfields.Why
The slicer decomposes an issue into disjoint slices, unions them (
integrate), and checks the union against a pinned contract (reconcile). This lands the CRD surface those two steps ride on, so a rendered sliced Workload validates against the apiserver. It's API-only: no executor handling yet (the follow-up wires the two kinds to theslicerlibraries in #1034 / #1036).How
New API types
SliceRefandSharedIdentifierlive inapi/foreman/v1alpha1(the API package stays independent ofpkg/foreman/slicer; the executor converts between them). Regenerated deepcopy, CRD manifests, and chart CRDs. The AgenticTask validating webhook only checks thatagentRefresolves, so no webhook change was needed.Testing
go build ./...,go vet,gofmt,golangci-lint,go test ./api/foreman/...all clean. Re-runningmake manifests chart-crds foreman-chart-crdsproduces no further drift, so the CRD Sync Check passes.Checklist
go build/go vet/gofmt/golangci-lint/go test ./api/...cleanPart of #1033
Assisted-by: Claude Code (Opus 4.8); reviewed and verified by the author.