feat(foreman): ship default integrate/reconcile Agents for sliced workloads#1052
Merged
Conversation
…kloads The Sliced Workloads pipeline (defilantech#1033) dispatches an integrate step (run_integrate) and a reconcile step (run_reconcile), but no Agent CRs backed them, so a rendered sliced Workload failed at those steps with 'agent not found'. Add the two deterministic Agents under config/foreman/agents/ mirroring gate.yaml (no inferenceServiceRef, tool-only). Unlike the gate (which runs a remote Job on a verifier node), integrate/reconcile do LOCAL git in the agent workspace, so they requiredCapability roles: [coder] to schedule onto a node whose foreman-agent has --git-remote-url configured. Fixes defilantech#1051 Signed-off-by: Christopher Maher <chris@mahercode.io>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add default
integrateandreconcileAgent manifests underconfig/foreman/agents/, so a Sliced Workload (#1033) runs out of the box.Why
The sliced pipeline dispatches an
integratestep (run_integratetool) and areconcilestep (run_reconciletool). Both are deterministic Agents (noinferenceServiceRef, tool-only), but none were shipped, so a rendered sliced Workload failed at those steps with "agent not found." Every other pipeline role already has a checked-in reference manifest here (gate.yaml, coders, reviewers); these two were the gap.How
Mirror
config/foreman/agents/gate.yaml:role: verifier, deterministic (noinferenceServiceRef/systemPrompt),tools: [run_integrate]/[run_reconcile],requiredCapability.roles: [coder]— unlike the gate (remote Job on a verifier node), integrate/reconcile do a local git clone/union/read in the agent workspace, so they must land on a node whose foreman-agent has--git-remote-urlset. Operators adjust to match their fleet's FleetNode roles.Per
gate.yaml's own convention, these are checked-in workload-data applied withkubectl apply -f, not chart templates (the chart installs the controller). Chart-templating default agents is noted as a follow-up in #1051.Testing
Both parse as valid
AgentCRs (kind/role/tools present). Not covered by a codegen or sync check (sync-reviewer-promptsonly touches*-reviewer.yaml).Checklist
Fixes #1051
Assisted-by: Claude Code (Opus 4.8); reviewed and verified by the author.