Fix implicit nullable parameter deprecations for PHP 8.4#52
Open
nige-one wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters (typed parameters with a
nulldefault but no explicit nullable type). Loading these classes on PHP 8.4 raises:In Magento developer mode this deprecation is escalated to an exception by
Magento\Framework\App\ErrorHandler, which breakssetup:di:compile(proxy/repository code generation reflects these constructors).This PR adds the explicit
?nullable type to the four affected parameters:Model/CustomReport.php:$resource,$resourceCollectionModel/GenericReportCollection.php:$connection,$resourceConnectionNo behavior change — the explicit nullable type is identical to the previous implicit semantics and remains compatible with PHP 7.1+.
Related: #51