Skip to content

Comments

CI bug fix#336

Open
trampler wants to merge 7 commits intodfki-ric:phobos-ci-stablefrom
trampler:ci_fix
Open

CI bug fix#336
trampler wants to merge 7 commits intodfki-ric:phobos-ci-stablefrom
trampler:ci_fix

Conversation

@trampler
Copy link

  • The default parameter of include_unstopped_branches is inconsistent and results in a failed assertion with submodels
  • PyBullet availability check was not working
  • The submodel definition is a dictionary (at least for me)

hwiedPro added a commit that referenced this pull request Feb 13, 2024
with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None):
with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None,
submodels=None):
""" Export self and all annotations inside a given folder with structure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a new feature, could you please open a separate PR for this?

@hwiedPro
Copy link
Collaborator

Hi @trampler ,
The fixes I included in the marked commits on develop.

The selectable submodels for the export_smurf seems a cool new feature, ould you open a separate PR for those?

The issue with the include_unstopped_branches, didn't yet occur for me. Do you have an example where this leads to problems?

Best,
Henning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants