-
Notifications
You must be signed in to change notification settings - Fork 135
CI bug fix #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trampler
wants to merge
7
commits into
dfki-ric:phobos-ci-stable
Choose a base branch
from
trampler:ci_fix
base: phobos-ci-stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI bug fix #336
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1fd1d53
fixed ci tests with submodels
cb9199f
fixed different default parameter for include_unstopped_branches
fd79226
fixed ci tests with submodels
35317c7
fixed different default parameter for include_unstopped_branches
510d961
fix: only add exported submodels to submodel smurf file
130ca7e
resolved conflict
3c833ce
fixed missing key arg error for sensors without link or joint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -258,7 +258,8 @@ def export_xml(self, outputdir=None, format="urdf", filename=None, float_fmt_dic | |
|
|
||
| def export_smurf(self, outputdir=None, outputfile=None, robotfile=None, | ||
| check_submechs=True, with_submodel_defs=False, | ||
| with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None): | ||
| with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None, | ||
| submodels=None): | ||
| """ Export self and all annotations inside a given folder with structure | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be a new feature, could you please open a separate PR for this? |
||
| """ | ||
| assert self.check_linkage() | ||
|
|
@@ -355,9 +356,14 @@ def export_smurf(self, outputdir=None, outputfile=None, robotfile=None, | |
| # submodel list | ||
| if with_submodel_defs and len(self.submodel_defs) > 0: | ||
| out_submodel_defs = {} | ||
| for name, definition in self.submodel_defs.items(): | ||
| out_submodel_defs[name] = deepcopy(definition) | ||
| out_submodel_defs[name]["export_dir"] = os.path.relpath(out_submodel_defs[name]["export_dir"], smurf_dir) | ||
| if submodels is not None: | ||
| for name in submodels: | ||
| out_submodel_defs[name] = deepcopy(self.submodel_defs[name]) | ||
| out_submodel_defs[name]["export_dir"] = os.path.relpath(out_submodel_defs[name]["export_dir"], smurf_dir) | ||
| else: | ||
| for name, definition in self.submodel_defs.items(): | ||
| out_submodel_defs[name] = deepcopy(definition) | ||
| out_submodel_defs[name]["export_dir"] = os.path.relpath(out_submodel_defs[name]["export_dir"], smurf_dir) | ||
| with open(os.path.join(smurf_dir, "{}_submodels.yml".format(self.name.replace('/','_'))), "w+") as stream: | ||
| stream.write(dump_json({"submodels": out_submodel_defs}, default_style=False)) | ||
| export_files.append(os.path.split(stream.name)[-1]) | ||
|
|
@@ -722,7 +728,7 @@ def export(self, outputdir, export_config=None, rel_mesh_pathes=None, ros_pkg_na | |
| name=export["name"], | ||
| start=export.get("start", None), | ||
| stop=export.get("stop", None), | ||
| include_unstopped_branches=export.get("include_unstopped_branches", None), | ||
| include_unstopped_branches=export.get("include_unstopped_branches", False), | ||
| no_submechanisms=export.get("no_submechanisms", False), | ||
| abstract_model=export.get("abstract_model", False), | ||
| remove_fixed=export.get("remove_fixed", False), | ||
|
|
@@ -785,7 +791,8 @@ def export(self, outputdir, export_config=None, rel_mesh_pathes=None, ros_pkg_na | |
| robotfile=xml_file_in_smurf, | ||
| check_submechs=check_submechs, | ||
| with_submodel_defs=True, | ||
| with_meshes=False # has been done before | ||
| with_meshes=False, # has been done before | ||
| submodels=[filtered_item['name'] for filtered_item in filter(lambda item: item["type"] == "submodel", export_config)] | ||
| ) | ||
| # export ros package files | ||
| if ros_pkg and not ros_pkg_later: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.