Skip to content

[20.10 backport] test/cli: Use empty array as empty output of images/json#4060

Merged
thaJeztah merged 1 commit into
docker:20.10from
vvoland:test-fakecli-images-mock-2010
Mar 3, 2023
Merged

[20.10 backport] test/cli: Use empty array as empty output of images/json#4060
thaJeztah merged 1 commit into
docker:20.10from
vvoland:test-fakecli-images-mock-2010

Conversation

@vvoland

@vvoland vvoland commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Tests mocking the output of GET images/json with fakeClient used an array with one empty element as an empty response. Change it to just an empty array.

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com
(cherry picked from commit a1953e1)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Tests mocking the output of GET images/json with fakeClient used an
array with one empty element as an empty response.
Change it to just an empty array.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit a1953e1)
@vvoland vvoland added area/testing kind/bugfix PR's that fix bugs labels Mar 1, 2023
@vvoland vvoland added this to the 20.10.24 milestone Mar 1, 2023

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 3825ed5 into docker:20.10 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants