Pass remaining arguments to arcade build.ps1 in test step#5801
Closed
max-charlamb wants to merge 1 commit intomainfrom
Closed
Pass remaining arguments to arcade build.ps1 in test step#5801max-charlamb wants to merge 1 commit intomainfrom
max-charlamb wants to merge 1 commit intomainfrom
Conversation
The test invocation of arcade's build.ps1 was not forwarding remaining arguments, preventing callers from passing -projects or other arcade parameters for test runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlamb
pushed a commit
to max-charlamb/runtime
that referenced
this pull request
Apr 13, 2026
The runtime-diagnostics pipeline runs all diagnostics tests including EventPipe monitoring tests which are flaky and unrelated to the DAC/cDAC validation this pipeline exists for. Filter the cDAC and DAC test legs to only run SOS.UnitTests by passing -projects to the diagnostics build script. Depends on dotnet/diagnostics#5801 which forwards remaining arguments to arcade's build.ps1 in the test step. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
The corresponding runtime pipeline change that depends on this PR: dotnet/runtime#126855 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
$remainingargsthrough to arcade'sbuild.ps1in the test step ofeng/build.ps1.Currently remaining arguments (like
-projects) are forwarded for the managed build step (line 73) but not for the test step. This prevents callers from passing arcade parameters like-projectsto scope which test projects are run.Change
Add
$remainingargsto the test invocation of arcade'sbuild.ps1.This enables the
runtime-diagnosticspipeline in dotnet/runtime to pass-projectsto run only specific test projects (e.g.SOS.UnitTests.csproj), avoiding unrelated flaky test failures fromEventPipe.UnitTests.Note
This PR was generated with the assistance of GitHub Copilot.