Filter runtime-diagnostics pipeline to SOS tests only#126855
Merged
max-charlamb merged 1 commit intodotnet:mainfrom Apr 14, 2026
Merged
Filter runtime-diagnostics pipeline to SOS tests only#126855max-charlamb merged 1 commit intodotnet:mainfrom
max-charlamb merged 1 commit intodotnet:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Add classFilter parameter to runtime-diag-job.yml that passes -classfilter to the diagnostics build script, filtering xunit tests by class name. Set classFilter to SOS for both cDAC and DAC legs, avoiding unrelated EventPipe test failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlamb
force-pushed
the
fix/runtime-diagnostics-sos-only
branch
from
23df05f to
6473591
Compare
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
noahfalk
approved these changes
Apr 14, 2026
Member
Author
|
/ba-g runtime diagnostics pipeline change only |
Member
Author
|
/azp run runtime-diagnostics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filter the
runtime-diagnosticspipeline's cDAC and DAC test legs to only run SOS tests, which are the tests that actually exercise the DAC/cDAC with a locally-built runtime.Problem
The
runtime-diagnosticspipeline runs ALL diagnostics test projects, including EventPipe monitoring, dotnet-counters, DbgShim, and other tests that don't depend on the runtime's DAC implementation. TheMicrosoft.Diagnostics.Monitoring.EventPipe.UnitTestshave been consistently failing since April 10, blocking all builds.These other tests are already covered by the diagnostics repo's own CI (
diagnostics-public-ci) and don't need to run against a privately-built runtime.Changes
runtime-diag-job.yml: AddclassFilterparameter that passes-classfilterto the diagnosticsbuild.ps1runtime-diagnostics.yml: SetclassFilter: SOSfor both cDAC and DAC legsThis uses the existing
-classfiltersupport in the diagnosticsbuild.ps1, which translates to xunit's-classfilter. Only theSOStest class (27+ test methods covering DivZero, StackTests, OtherCommands, GCTests, DotnetDumpCommands, etc.) will run.Note
This PR was generated with the assistance of GitHub Copilot.