Skip to content

Comments

Fix incorrect Direction for max parameter in InRangeCall/OutRangeCall#23

Merged
jogibear9988 merged 2 commits intomainfrom
copilot/fix-inrangecall-outrangecall-issues
Feb 21, 2026
Merged

Fix incorrect Direction for max parameter in InRangeCall/OutRangeCall#23
jogibear9988 merged 2 commits intomainfrom
copilot/fix-inrangecall-outrangecall-issues

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

Both InRangeCall and OutRangeCall incorrectly assigned Direction.Output to the max parameter — it's an input bound, not an output.

Changes

  • InRangeCall.cs / OutRangeCall.cs: Changed max parameter direction from Direction.OutputDirection.Input, consistent with min and in
// Before (wrong)
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Output);

// After (correct)
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Input);
Original prompt

This section details on the original issue you should resolve

<issue_title>Fix issues in InRangeCall/OutRangeCall copilot found in #21</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…all and OutRangeCall

Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues in InRangeCall and OutRangeCall Fix incorrect Direction for max parameter in InRangeCall/OutRangeCall Feb 21, 2026
Copilot AI requested a review from jogibear9988 February 21, 2026 14:09
@jogibear9988 jogibear9988 marked this pull request as ready for review February 21, 2026 14:11
@jogibear9988 jogibear9988 merged commit dca59ba into main Feb 21, 2026
1 check passed
@jogibear9988 jogibear9988 deleted the copilot/fix-inrangecall-outrangecall-issues branch February 21, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues in InRangeCall/OutRangeCall copilot found in #21

2 participants