Skip to content

Fix incorrect Direction for max parameter in InRangeCall/OutRangeCall #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jogibear9988 merged 2 commits into from
Feb 21, 2026
+2 −2
Merged

Fix incorrect Direction for max parameter in InRangeCall/OutRangeCall #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b87a576
Initial plan
Copilot Feb 21, 2026
7ecb5f0
Fix Direction.Output -> Direction.Input for max parameter in InRangeC…
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TiaCodegen/Commands/Comparisons/InRangeCall.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public InRangeCall(
DisableEno = false;
Interface["min"] = new IOperationOrSignalDirectionWrapper(min, Direction.Input);
Interface["in"] = new IOperationOrSignalDirectionWrapper(@in, Direction.Input);
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Output);
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Input);
Interface["out"] = new IOperationOrSignalDirectionWrapper(@out, Direction.Output);

Children.AddRange(Interface.Values.Where(x => x.OperationOrSignal != null).Select(x => x.OperationOrSignal));
Expand Down
2 changes: 1 addition & 1 deletion TiaCodegen/Commands/Comparisons/OutRangeCall.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public OutRangeCall(
DisableEno = false;
Interface["min"] = new IOperationOrSignalDirectionWrapper(min, Direction.Input);
Interface["in"] = new IOperationOrSignalDirectionWrapper(@in, Direction.Input);
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Output);
Interface["max"] = new IOperationOrSignalDirectionWrapper(max, Direction.Input);
Interface["out"] = new IOperationOrSignalDirectionWrapper(@out, Direction.Output);

Children.AddRange(Interface.Values.Where(x => x.OperationOrSignal != null).Select(x => x.OperationOrSignal));
Expand Down