Skip to content

This PR removes the interfaces folder. #113

Merged
bvadorno merged 1 commit intodqrobotics:masterfrom
juanjqo:inter_rem
Apr 30, 2025
Merged

This PR removes the interfaces folder. #113
bvadorno merged 1 commit intodqrobotics:masterfrom
juanjqo:inter_rem

Conversation

@juanjqo
Copy link
Copy Markdown
Member

@juanjqo juanjqo commented Apr 23, 2025

Main instructions

By submitting this pull request, you automatically agree that you have read and accepted the following conditions:

  • Anyone wanting to propose a new modification or introduce new functionality should reach out to the team first, as proposed modifications that do not comply with the library's development philosophy and style, do not follow the library's architecture, do not introduce a clear and general benefit to the library other than to the person who proposed the modification will likely be rejected with no further discussion.
  • Support for DQ Robotics is given voluntarily, and it is not the developers' role to educate and/or convince anyone of their vision.
  • Any possible response and its timeliness will be based on the relevance, accuracy, and politeness of a request and the following discussion.
  • You are familiar with the development workflow.
  • Each pull request should contain only individual changes (several changes of the same type are allowed on the same pull request).
  • Refactoring or modifying an internal implementation that is working is not allowed unless comprehensively discussed with and approved by @bvadorno and @mmmarinho.

Description of changes

This PR removes the folder interfaces, which contains the DQ_VrepInterface class and other related classes. This folder will be available in an archived repository. Now, the interfaces have their separate repositories (e.g., matlab-interface-coppeliasim, matlab-interface-coppeliasim-zmq).

Kind regards,

Juancho

@bvadorno
Copy link
Copy Markdown
Member

Thanks, @juanjqo.

Before I accept those modifications, I'd like to see the checks completed. Could you please set up a runner on one of our computers at RAICo?

Kind regards,
Bruno

@juanjqo juanjqo marked this pull request as draft April 23, 2025 16:00
@juanjqo juanjqo marked this pull request as ready for review April 24, 2025 08:55
@juanjqo juanjqo marked this pull request as draft April 24, 2025 09:08
@juanjqo juanjqo marked this pull request as ready for review April 24, 2025 15:22
@juanjqo juanjqo marked this pull request as draft April 24, 2025 15:22
@juanjqo juanjqo marked this pull request as ready for review April 28, 2025 09:10
@juanjqo
Copy link
Copy Markdown
Member Author

juanjqo commented Apr 29, 2025

Thanks, @juanjqo.

Before I accept those modifications, I'd like to see the checks completed. Could you please set up a runner on one of our computers at RAICo?

Kind regards, Bruno

Hi @bvadorno,

I set up the runner and GitHub actions is working now.

Kind regards,

Juancho

@bvadorno bvadorno merged commit 8a2f58e into dqrobotics:master Apr 30, 2025
1 of 6 checks passed
@juanjqo juanjqo deleted the inter_rem branch May 6, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants