Skip to content

Fix the portal host issue#1035

Merged
YoussefHenna merged 2 commits into
masterfrom
sieu/fix-portal-host-issue
Jun 1, 2026
Merged

Fix the portal host issue#1035
YoussefHenna merged 2 commits into
masterfrom
sieu/fix-portal-host-issue

Conversation

@sieu-db
Copy link
Copy Markdown
Collaborator

@sieu-db sieu-db commented Jun 1, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pointerEvents value from "none" to "box-none" in the stylesheet of PortalHost.tsx. However, as noted in the review, pointerEvents is a component prop of View rather than a valid style property in React Native. It should be removed from the stylesheet and applied directly as a prop to the View component to avoid TypeScript compilation errors and ensure correct behavior on native platforms.

Comment on lines 138 to +139
flex: 1,
pointerEvents: "none",
pointerEvents: "box-none",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In React Native, pointerEvents is a component prop of View (i.e., <View pointerEvents="box-none">), not a style property. Defining it inside StyleSheet.create will not work on native platforms and will cause TypeScript compilation errors because pointerEvents is not a valid property of ViewStyle.

Please remove it from the stylesheet and apply it as a prop to the <View> component at line 127:

<View pointerEvents="box-none" style={styles.container} collapsable={false}>
Suggested change
flex: 1,
pointerEvents: "none",
pointerEvents: "box-none",
flex: 1,

@YoussefHenna YoussefHenna merged commit 5a79349 into master Jun 1, 2026
3 of 4 checks passed
@YoussefHenna YoussefHenna deleted the sieu/fix-portal-host-issue branch June 1, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants