Skip to content

Fix the portal host issue #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoussefHenna merged 2 commits into from
Jun 1, 2026
Merged

Fix the portal host issue #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46f42a
fix the portal host issue
sieu-db Jun 1, 2026
71a3c9b
portal manager box-none
YoussefHenna Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/Portal/PortalHost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,6 @@ export default class PortalHost extends React.Component<Props> {
const styles = StyleSheet.create({
container: {
flex: 1,
pointerEvents: "none",
pointerEvents: "box-none",
Comment on lines 138 to +139
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In React Native, pointerEvents is a component prop of View (i.e., <View pointerEvents="box-none">), not a style property. Defining it inside StyleSheet.create will not work on native platforms and will cause TypeScript compilation errors because pointerEvents is not a valid property of ViewStyle.

Please remove it from the stylesheet and apply it as a prop to the <View> component at line 127:

<View pointerEvents="box-none" style={styles.container} collapsable={false}>
Suggested change
flex: 1,
pointerEvents: "none",
pointerEvents: "box-none",
flex: 1,

},
});
2 changes: 1 addition & 1 deletion packages/core/src/components/Portal/PortalManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default class PortalManager extends React.PureComponent<object, State> {
collapsable={
false /* Need collapsable=false here to clip the elevations, otherwise they appear above sibling components */
}
style={[StyleSheet.absoluteFill, { pointerEvents: "none" }]}
style={[StyleSheet.absoluteFill, { pointerEvents: "box-none" }]}
>
{children}
</View>
Expand Down