Skip to content

feat(configure): add automatic HTTPS scheme for server URLs without s…#39

Merged
monoxgas merged 1 commit into
mainfrom
feat/configure-server-scheme
May 12, 2025
Merged

feat(configure): add automatic HTTPS scheme for server URLs without s…#39
monoxgas merged 1 commit into
mainfrom
feat/configure-server-scheme

Conversation

@briangreunke
Copy link
Copy Markdown
Contributor

@briangreunke briangreunke commented Apr 30, 2025

Automatic HTTPS Scheme for Server URLs

Key Changes:

  • Add functionality to automatically prefix server URLs with HTTPS scheme
  • Parse URLs without scheme and reconstruct them with HTTPS
  • Preserve path components when reconstructing URLs

Added:

  • URL handling logic that detects missing schemes in server URLs
  • Import of additional URL parsing functions (urlparse, urlunparse)

Changed:

  • Enhanced URL handling in the Dreadnode class
  • Import statement expanded to include additional URL parsing utilities

Removed:

  • N/A

Generated Summary:

  • Refactored the server URL handling in the Dreadnode class.
  • Added a check for the presence of a scheme in the self.server URL.
  • If the scheme is missing, the code now defaults to https and reconstructs the URL.
  • This change improves URL handling, ensuring that all URLs processed by the application are valid and secure.
  • Potential impact: May prevent connectivity issues if improperly formatted URLs are passed, enhancing reliability.

This summary was generated with ❤️ by rigging

This PR improves user experience by allowing server URLs to be entered without
explicitly specifying the HTTPS scheme. When a URL is provided without a scheme,
the system will automatically prepend "https://" to ensure secure connections
by default.

For example, "example.com/api" will be transformed to "https://example.com/api"
automatically.

…cheme

If server URL is provided without a scheme, it will automatically
be prefixed with HTTPS. This improves usability by letting users
enter just the domain name while maintaining secure connections.
@monoxgas monoxgas self-requested a review May 2, 2025 19:15
@monoxgas monoxgas merged commit 517bbeb into main May 12, 2025
9 checks passed
@monoxgas monoxgas deleted the feat/configure-server-scheme branch June 17, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants