Skip to content

feat(configure): add automatic HTTPS scheme for server URLs without s… #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monoxgas merged 1 commit into from
May 12, 2025
Merged

feat(configure): add automatic HTTPS scheme for server URLs without s… #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dreadnode/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from dataclasses import dataclass
from datetime import datetime, timezone
from pathlib import Path
from urllib.parse import urljoin
from urllib.parse import urljoin, urlparse, urlunparse

import coolname # type: ignore [import-untyped]
import logfire
Expand Down Expand Up @@ -205,6 +205,16 @@ def initialize(self) -> None:
category=DreadnodeConfigWarning,
)

if self.server:
parsed_url = urlparse(self.server)
if not parsed_url.scheme:
netloc = parsed_url.path.split("/")[0]
path = "/".join(parsed_url.path.split("/")[1:])
parsed_new = parsed_url._replace(
scheme="https", netloc=netloc, path=f"/{path}" if path else ""
)
self.server = urlunparse(parsed_new)

if self.local_dir is not False:
config = FileExportConfig(
base_path=self.local_dir,
Expand Down
Loading