Skip to content

fix: Log trainer callback metrics to run (ENG-1911)#47

Merged
monoxgas merged 1 commit into
mainfrom
nick/eng-1911-normalize-epoch-loss-metric-names-for-continuous
May 9, 2025
Merged

fix: Log trainer callback metrics to run (ENG-1911)#47
monoxgas merged 1 commit into
mainfrom
nick/eng-1911-normalize-epoch-loss-metric-names-for-continuous

Conversation

@monoxgas
Copy link
Copy Markdown
Contributor

@monoxgas monoxgas commented May 9, 2025

  • Updated metric logging calls in DreadnodeCallback to include to="run" parameter.
  • Changed the following logging statements:
    • dn.log_metric("epoch", state.epoch) to dn.log_metric("epoch", state.epoch, to="run")
    • dn.log_metric("step", state.global_step) to dn.log_metric("step", state.global_step, to="run")
    • Added to="run" to dynamic metric logging for cleaned keys.

Generated Summary:

  • Updated metric logging calls in DreadnodeCallback to consistently include the to="run" parameter.
  • Changes made to the following methods:
    • log_metric for epoch in the method handling epoch logging.
    • log_metric for step in the method handling step logging.
    • log_metric in the method iterating through cleaned keys in logs.
  • These modifications ensure that metrics are correctly associated with the current run, potentially improving tracking and debugging capabilities.

This summary was generated with ❤️ by rigging

@monoxgas monoxgas merged commit 4d03a2e into main May 9, 2025
9 checks passed
@monoxgas monoxgas deleted the nick/eng-1911-normalize-epoch-loss-metric-names-for-continuous branch June 17, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant