Skip to content

fix: Log trainer callback metrics to run (ENG-1911) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monoxgas merged 1 commit into from
May 9, 2025
Merged

fix: Log trainer callback metrics to run (ENG-1911) #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dreadnode/integrations/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def on_epoch_begin(
if self._run is None or state.epoch is None:
return

dn.log_metric("epoch", state.epoch)
dn.log_metric("epoch", state.epoch, to="run")

self._epoch_span = dn.task_span(f"Epoch {state.epoch}")
self._epoch_span.__enter__()
Expand All @@ -149,7 +149,7 @@ def on_step_begin(
if self._run is None:
return

dn.log_metric("step", state.global_step)
dn.log_metric("step", state.global_step, to="run")

self._step_span = dn.span(f"Step {state.global_step}")
self._step_span.__enter__()
Expand Down Expand Up @@ -178,6 +178,6 @@ def on_log(

for key, value in _clean_keys(logs).items():
if isinstance(value, float | int):
dn.log_metric(key, value, step=state.global_step)
dn.log_metric(key, value, step=state.global_step, to="run")

dn.push_update()
Loading