New range-only lifters#4
Merged
Merged
Conversation
Owner
Author
|
Moreover, this pull request introduces changes to the documentation workflow and removes outdated build artifacts and generated files. The most important updates include adding a GitHub Pages deployment step to the documentation workflow and cleaning up obsolete files in the Workflow Updates:
Cleanup of Generated Files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
popcorlibrary, including the addition of new lifters, refactoring of existing ones, and enhancements to type annotations for better clarity and maintainability. The most important changes involve the creation of theRangeOnlyLifterbase class, two new specialized lifters (RangeOnlyNsqLifterandRangeOnlySqLifter), and improvements to type definitions for gradient and Hessian methods.New Lifters and Refactoring:
popcor/base_lifters/__init__.py: Refactored imports to include the newRangeOnlyLifterbase class and addedRangeOnlyLifterto the module.popcor/base_lifters/range_only_lifter.py: Added theRangeOnlyLifterbase class, which provides foundational functionality for range-only localization in 2D or 3D. It includes methods for sampling parameters, computing residuals, and solving localization problems.Specialized Range-Only Lifters:
popcor/examples/__init__.py: Updated imports to include two new lifters,RangeOnlyNsqLifterandRangeOnlySqLifter, which extend the functionality ofRangeOnlyLifterfor specific use cases.popcor/examples/ro_nsq_lifter.py: AddedRangeOnlyNsqLifter, a specialized implementation for range-only localization without squaring distances. This lifter introduces advanced formulations, including normal vectors and quadratic substitutions.Type Annotation Enhancements:
popcor/base_lifters/state_lifter.py: Updated type annotations forget_gradandget_hessmethods to returnnp.ndarrayinstead offloat, improving clarity and aligning with their actual return types.