Better handling of DOI service errors#1319
Merged
markpatton merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
|
jaredgalanis
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds specific error messages for the different DOI service error conditions.
Also the invalid doi message is not displayed when there is an actual message from the DOI service.
The big change is that now a DOI to something other than an article is handled better.
For example try
https://doi.org/10.1017/CBO9781107445253.This pr should be tested against eclipse-pass/pass-core#134, but will work without it.