Skip to content

Better handling of DOI service errors #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markpatton merged 2 commits into from
Mar 23, 2026
Merged

Better handling of DOI service errors #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29fa6a5
Add better human readable messages for DOI service errors.
markpatton Mar 20, 2026
8c7346c
Do not display invalid DOI error message when there is an error from …
markpatton Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/workflow-basics/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,12 +526,12 @@ export default class WorkflowBasics extends Component<WorkflowBasicsSignature> {
{{on 'input' this.handleDoiInput}}
/>
<div class='text-danger'>
{{if (and @publication.doi (not this.isValidDOI)) 'Please provide a valid DOI'}}
{{if (and @publication.doi (not this.isValidDOI) (not this.doiServiceError)) 'Please provide a valid DOI'}}
</div>
{{#if this.doiServiceError}}
<div class='text-danger'>
{{! @glint-expect-error - doiServiceError is unknown but rendered as HTML }}
{{{this.doiServiceError}}}
{{{this.doiServiceError.message}}}
</div>
{{/if}}
</div>
Expand Down
14 changes: 14 additions & 0 deletions app/services/doi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,20 @@ export default class DoiService extends Service {
},
});

if (rawResponse.status === 404) {
throw new Error('DOI not found.');
}

if (rawResponse.status === 422) {
throw new Error(
'Unable to find a journal associated with the DOI. The DOI must resolve to an article or manuscript.',
);
}

if (rawResponse.status === 500) {
throw new Error('Error accessing DOI service.');
}

const response = await rawResponse.json();

const { content: journalDoc } = await this.store.request(findRecord('journal', response['journal-id']));
Expand Down
Loading