[Gtk4] Fix caret not painted on GTK4 with Snippet74#3356
Merged
Conversation
Member
akurtakov
commented
Jun 2, 2026
akurtakov
commented
- Override hooksPaint() in Canvas to enable the Cairo draw pipeline when a caret is showing
- Use isShowing (not blink) in drawCaretInFocus() for GTK4 fresh so repaints don't erase the caret
- Skip drawFlag on GTK4 and use foreground color with CAIRO_OPERATOR_OVER instead of DIFFERENCE against transparent surface
- Fix gtk4_focus_leave_event calling setFocus() instead of killFocus()
* Override hooksPaint() in Canvas to enable the Cairo draw pipeline when a caret is showing * Use isShowing (not blink) in drawCaretInFocus() for GTK4 fresh so repaints don't erase the caret * Skip drawFlag on GTK4 and use foreground color with CAIRO_OPERATOR_OVER instead of DIFFERENCE against transparent surface * Fix gtk4_focus_leave_event calling setFocus() instead of killFocus()
Contributor
jonahgraham
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.