Skip to content

Fix failing fckit_test_shared_ptr with aocc by detecting compiler bug#80

Merged
wdeconinck merged 2 commits into
developfrom
bugfix/79-aocc-failed-test
Jan 26, 2026
Merged

Fix failing fckit_test_shared_ptr with aocc by detecting compiler bug#80
wdeconinck merged 2 commits into
developfrom
bugfix/79-aocc-failed-test

Conversation

@wdeconinck
Copy link
Copy Markdown
Member

This PR addresses #79

This does not actually fix the underlying compiler bug but rather disables a now known to fail check.

during configuration

This does not actually fix the underlying compiler bug but rather
disables a now known to fail check
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 23.52941% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.07%. Comparing base (f104a7d) to head (61ebe64).

Files with missing lines Patch % Lines
cmake/final-support.F90 0.00% 39 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    51.35%   51.07%   -0.28%     
===========================================
  Files           58       58              
  Lines         4812     4854      +42     
  Branches       449      453       +4     
===========================================
+ Hits          2471     2479       +8     
- Misses        2341     2375      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdeconinck wdeconinck merged commit 7305cf3 into develop Jan 26, 2026
185 of 190 checks passed
@wdeconinck wdeconinck deleted the bugfix/79-aocc-failed-test branch February 17, 2026 09:56
wdeconinck added a commit that referenced this pull request Feb 23, 2026
* hotfix/0.14.2:
  Version 0.14.2
  Replace use of deprecated Library::lookup (#84)
  Add fortran linker flag submitted by AMD for AOCC (and Classic Flang) (#82)
  Workaround for failing fckit_test_shared_ptr with aocc/nvhpc/intel by detecting compiler bugs (#80)
  FCKIT_VENV_INSTALL: add a new ecbuild feature to control the (#78)
  Add miniumum cmake version check in wheel download macro (#75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants