[ML] Default to Linux x86_64 only for QA/PyTorch test comments#3001
Merged
edsavage merged 1 commit intoelastic:mainfrom Mar 20, 2026
Merged
[ML] Default to Linux x86_64 only for QA/PyTorch test comments#3001edsavage merged 1 commit intoelastic:mainfrom
edsavage merged 1 commit intoelastic:mainfrom
Conversation
When "buildkite run_qa_tests" or "buildkite run_pytorch_tests" is triggered via a PR comment without explicit platform/arch options, default to building only Linux x86_64 instead of all platforms. QA and PyTorch tests only run against Linux x86_64 builds so the Windows, macOS, and aarch64 builds were unnecessary. Made-with: Cursor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildkite run_qa_testsorbuildkite run_pytorch_testsis triggered via a PR comment without expliciton <platform>or<arch>options, default to building only Linux x86_64 instead of all platforms and architectures.pipeline.json.pylines 52-61), so the Windows, macOS, and aarch64 builds were wasted CI resources.buildkite run_qa_tests on linux, macos x86_64, aarch64) continue to work as before.Test plan - after this is merged to main
buildkite run_qa_testson a PR and verify only the Linux x86_64 build + QA tests runbuildkite run_qa_tests on linux, macos x86_64, aarch64and verify platform/arch overrides still workbuildkite buildand verify all platforms still build as beforeMade with Cursor