Skip to content

[ML] Default to Linux x86_64 only for QA/PyTorch test comments #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsavage merged 1 commit into from
Mar 20, 2026
+7 −3
Merged

[ML] Default to Linux x86_64 only for QA/PyTorch test comments #3001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .buildkite/ml_pipeline/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,24 @@ def parse_comment(self):
if "GITHUB_PR_COMMENT_VAR_ARGS" in os.environ:
os.environ["QAF_TESTS_TO_RUN"] = os.environ["GITHUB_PR_COMMENT_VAR_ARGS"]

# If the GITHUB_PR_COMMENT_VAR_ARCH environment variable is set then attemot to parse it
# If the GITHUB_PR_COMMENT_VAR_ARCH environment variable is set then attempt to parse it
# into comma separated values. If the values are one or both of "aarch64" or "x86_64" then set the member
# variables self.build_aarch64, self.build_x86_64 accordingly. These values will be used to restrict the build
# jobs to a particular achitecture.
# jobs to a particular architecture.
if "GITHUB_PR_COMMENT_VAR_ARCH" in os.environ:
csv_arch = os.environ["GITHUB_PR_COMMENT_VAR_ARCH"]
for each in [ x.strip().lower() for x in csv_arch.split(",")]:
if each == "aarch64":
self.build_aarch64 = "--build-aarch64"
elif each == "x86_64":
self.build_x86_64 = "--build-x86_64"
elif self.run_qa_tests or self.run_pytorch_tests:
self.build_x86_64 = "--build-x86_64"
else:
self.build_aarch64 = "--build-aarch64"
self.build_x86_64 = "--build-x86_64"

# If the GITHUB_PR_COMMENT_VAR_PLATFORM environment variable is set to a non-empty string then attemot to parse it
# If the GITHUB_PR_COMMENT_VAR_PLATFORM environment variable is set to a non-empty string then attempt to parse it
# into comma separated values. If the values are one or a combination of "windows", "mac(os)", "linux" then set the member
# variables self.build_windows, self.build_macos, self.build_linux accordingly. These values will be used to restrict the build
# jobs to a particular platform.
Expand All @@ -81,6 +83,8 @@ def parse_comment(self):
self.build_macos = True
elif each == "linux":
self.build_linux = True
elif self.run_qa_tests or self.run_pytorch_tests:
self.build_linux = True
else:
self.build_windows = True
self.build_macos = True
Expand Down