Skip to content

Harden RRI handoff evidence bridge - #505

Merged
100yenadmin merged 1 commit into
mainfrom
codex/worldos-post504-truth-sync
Jun 1, 2026
Merged

Harden RRI handoff evidence bridge#505
100yenadmin merged 1 commit into
mainfrom
codex/worldos-post504-truth-sync

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds --handoff-json to qa/release_readiness.py so split Mac + support-VM RRI can consume a Mac qa/app_handoff_gate.py bundle as native/built-app proof.
  • Keeps the release gate strict: handoff proof must be clean, same-SHA, 100/100, include the three required gates, validate every manifest, prove private art/actions/move sink, and verify listed evidence files exist.
  • Treats malformed or schema-incomplete score.json as harness-contaminated evidence that does not complete a persona.
  • Updates takeover docs/scorecard to main@4a0efe1, records the post-Add 100/100 hybrid app handoff gate #504 handoff evidence, and documents support VM preflight blockers without tracked secrets.

Validation

  • python3 -m pytest qa/test_release_readiness.py qa/test_app_handoff_gate.py qa/test_export_app_evidence.py -q -> 31 passed
  • bash -n qa/release_gate.sh
  • python3 -m py_compile qa/release_readiness.py qa/app_handoff_gate.py
  • git diff --check
  • Real handoff bundle validation: /Volumes/LEXAR/Codex/worldos-agent-grade-app-testability/handoff-20260601T081016Z-4a0efe1/handoff.json validates with valid=True, gaps=0 against build 4a0efe1.

Release Note

This is not a release verdict. It makes the next #466 rollup stricter and able to combine Mac built-app evidence with support VM persona artifacts.

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated operational runbooks and guidelines to reflect current baseline and validation status
    • Expanded support VM preflight and checkout guidance with detailed configuration requirements
  • Tests

    • Enhanced release readiness validation to support additional artifact verification
    • Expanded test coverage for build artifact validation and evidence integrity

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c8fb47f9-0372-4394-a8be-743330ec260a

📥 Commits

Reviewing files that changed from the base of the PR and between 4a0efe1 and c56dd61.

📒 Files selected for processing (6)
  • WorldOS-GUI-RUNBOOK.md
  • WorldOS-OPERATING-GOAL.md
  • WorldOS-RUNBOOK.md
  • qa/SCORECARD.md
  • qa/release_readiness.py
  • qa/test_release_readiness.py

📝 Walkthrough

Walkthrough

This PR extends the release readiness scorer (qa/release_readiness.py) to accept and validate --handoff-json Mac app handoff proofs, enforce stricter score schema checking and cross-persona part_b.score_pass requirements, and derive the native gate from handoff evidence when persona run evidence is incomplete. The changes add comprehensive test coverage and update operational runbooks to track the new 4a0efe1 baseline and post-#504 handoff-gate status.

Changes

Handoff JSON validation and release readiness gating

Layer / File(s) Summary
Handoff validation constants and helper functions
qa/release_readiness.py
Constants for required handoff gates/evidence kinds and score fields; read_json_with_error() for precise JSON error reporting; build_sha_matches() for prefix-based SHA matching; score_schema_errors() for type/shape constraint violation detection; path resolvers and validate_handoff_json() pipeline that parses, gates, schemas, and verifies manifest/evidence files.
CLI parsing and handoff evidence ingestion
qa/release_readiness.py
Docstring and usage text updated to document --handoff-json option; CLI argument parsing adds --handoff-json and --build-sha arguments; validate_handoff_json() call integrated into main evidence pipeline; score.json loading switched to read_json_with_error() for better error distinction.
Enhanced score validation and persona pass tracking
qa/release_readiness.py
Harness failure handling now records schema/type violations when score.json loads but violates required-field constraints; new score_pass_complete computation tracks which personas fail part_b_score_pass.
Native gate derivation with handoff fallback
qa/release_readiness.py
Native gate evidence logic reworked: scans persona run.json for part_a results and records failures; if no native PASS found and handoff proof valid, derives native PASS from handoff_json with source/detail recorded; build-SHA mismatch detection switched to prefix-based build_sha_matches().
Evidence gap aggregation and cross-persona satisfaction
qa/release_readiness.py
Collects handoff-derived gaps and per-persona part_a failures into overall evidence_gaps list; updates cross_persona_sat gate to additionally require score_pass_complete; harness-failure formatting extended with richer missing-reason metadata.
Output payload with handoff proof and native gate signals
qa/release_readiness.py
Extended JSON output with artifact_sources.handoff_json, signals.native_gate_source, embedded handoff_proof validation result, and signals.score_pass_failed_personas.
Test infrastructure and release readiness contract tests
qa/test_release_readiness.py
New write_handoff_bundle(), write_release_inputs(), and write_persona_run() helper methods synthesize on-disk artifacts for tests; existing score fixtures updated with explicit console_errors: 0 field; new contract tests validate native-gate handoff scenarios (successful path, missing part_a, commit_sha mismatch, stale evidence via short SHA prefix, manifest reuse) and harness contamination/incompleteness (malformed score.json, missing console_errors, part_b.score_pass false).
Runbooks and scorecard operational status updates
WorldOS-GUI-RUNBOOK.md, WorldOS-OPERATING-GOAL.md, WorldOS-RUNBOOK.md, qa/SCORECARD.md
Commit baseline advanced to 4a0efe1 post-#504 merge; new "post-#504 merged-main handoff gate" section describes fastest GUI trust proof; SSH/VM routing and preflight status documented; RRI output contract extended to include --handoff-json and per-run Part B pass status; new handoff-gate scorecard entry (handoff-20260601T081016Z-4a0efe1 PASS) added.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related issues

  • electricsheephq/WorldOS#466: The extended qa/release_readiness.py enforces hardened RRI/gate evidence (including --handoff-json, stricter score/schema checks, and persona pass requirements) directly addressing the post-hardening clean non-partial five-persona RRI verification requested in this issue.

Possibly related PRs

  • electricsheephq/WorldOS#413: This PR directly extends the same qa/release_readiness.py RRI scorer with new --handoff-json parsing/validation and additional "native/built-app handoff" gate logic, building on the RRI tooling introduced in #413.
  • electricsheephq/WorldOS#496: The qa/release_readiness.py changes extend the release-readiness payload/gating logic with new handoff_proof and native_gate_source signals, which directly overlaps with PR #496's updates to release verdict contract fields.
  • electricsheephq/WorldOS#504: This PR's qa/release_readiness.py adds --handoff-json ingestion and validate_handoff_json() logic to verify the handoff.json produced by the #504 hybrid handoff gate, directly targeting the same handoff-gate output and pass/fail semantics.

Poem

🐰 A handoff so fair, now validated with care,
Proofs nested in gates, evidence everywhere,
Five personas must pass, their scores crystal clear,
From macOS proof to VM—the pipeline is here!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding handoff evidence validation to harden the RRI (Release Readiness Inspection) system.
Description check ✅ Passed The description is well-structured and comprehensive, covering summary, validation details, and release notes. All required template sections are present with substantive content.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@100yenadmin
100yenadmin force-pushed the codex/worldos-post504-truth-sync branch from c6137f1 to c56dd61 Compare June 1, 2026 08:38
@100yenadmin
100yenadmin marked this pull request as ready for review June 1, 2026 08:43
@100yenadmin

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@100yenadmin
100yenadmin merged commit fd9dba5 into main Jun 1, 2026
9 checks passed
@100yenadmin
100yenadmin deleted the codex/worldos-post504-truth-sync branch June 1, 2026 08:49
100yenadmin added a commit that referenced this pull request Jun 1, 2026
Update the takeover docs and scorecard so current gate truth points to main@fd9dba5 and the post-#505 handoff bundle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant