Skip to content

qa: expose structured RRI handoff evidence - #521

Merged
100yenadmin merged 1 commit into
mainfrom
codex/worldos-rri-structured-handoff
Jun 1, 2026
Merged

qa: expose structured RRI handoff evidence#521
100yenadmin merged 1 commit into
mainfrom
codex/worldos-rri-structured-handoff

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • add a top-level handoff_evidence object to RRI JSON output when --handoff-json is used
  • include the validated handoff proof plus any handoff evidence gaps in a stable machine-readable field
  • extend the release-readiness contract test so split Mac-app proof remains auditable without parsing gate_detail

Test Plan

  • python3 -m pytest qa/test_release_readiness.py -q -k split_vm_persona_evidence_uses_handoff_json_for_native_gate
  • python3 -m pytest qa/test_release_readiness.py -q
  • python3 -m pytest qa/test_release_readiness.py qa/test_app_handoff_gate.py qa/test_export_app_evidence.py -q
  • python3 -m py_compile qa/release_readiness.py
  • git diff --check

Licensing / CLA

  • I agree to contribute this change under the repository license.
  • This PR does not include confidential information, private artifacts, or private operator details.

Notes

  • This is release-evidence schema hardening only; it is not a release verdict.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR extends the release readiness output JSON to include a new handoff_evidence object that packages already-computed handoff_proof and evidence_gaps fields. A corresponding test is updated to validate the structure, path matching, validity, and manifest verdict assertions.

Changes

Handoff Evidence Reporting

Layer / File(s) Summary
Handoff evidence output and test coverage
qa/release_readiness.py, qa/test_release_readiness.py
The result JSON now includes a handoff_evidence block containing handoff_proof and evidence_gaps. Test assertions validate the handoff evidence path, validity flag, empty gaps list, expected gate keys, and built_app_codex_playtest manifest verdict.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • electricsheephq/WorldOS#505: The main PR's change to emit payload["handoff_evidence"] directly builds on #505's --handoff-json ingestion and evidence-gap/handoff_proof handling in qa/release_readiness.py.
  • electricsheephq/WorldOS#519: Both PRs touch qa/release_readiness.py around --handoff-json native-gate evidence; the main PR surfaces evidence_gaps in the exported handoff_evidence result, while the retrieved PR changes validate_handoff_json to compute those evidence_gaps.
  • electricsheephq/WorldOS#413: Both PRs extend the release readiness report structure in qa/release_readiness.py; #413 introduces the RRI scorer/reporting JSON, and the main PR adds handoff_evidence with proof and gaps.

Poem

🐰 A handoff takes shape, all gaps laid bare,
Evidence bundled with proof and care,
Tests verify the verdicts ring true,
Release readiness shines brightly through!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: exposing structured RRI handoff evidence in a new top-level object.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description includes summary, test plan, and licensing confirmation. However, CLA section does not match template format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@100yenadmin
100yenadmin merged commit 9fa1cd4 into main Jun 1, 2026
14 checks passed
@100yenadmin
100yenadmin deleted the codex/worldos-rri-structured-handoff branch June 1, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant