Clean inline Markdown from chronicle narration - #628
Conversation
|
Warning Review limit reached
More reviews will be available in 11 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds inline Markdown stripping to player-facing chronicle narration. A new ChangesInline Markdown stripping from player-facing narration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
5273c2c to
77488fb
Compare
77488fb to
ecd7f90
Compare
Summary
sanitizeNarrationpath so engine/provider text and campaign state remain unchanged.**11**in the Chronicle.Test Plan
python3 -m pytest viewer/tests/test_sanitize_narration.py::SanitizeNarrationTests::test_inline_markdown_emphasis_is_plain_text_for_players -qpython3 -m pytest viewer/tests/test_sanitize_narration.py -qpython3 -m pytest viewer/tests/test_openworlds_static.py -qgit diff --checkNotes
Summary by CodeRabbit
Release Notes