Mark network errors as retriable in authentication methods#61
Merged
Conversation
This change addresses an issue where network errors during authentication were being treated the same as invalid credentials, causing unnecessary reauth prompts when Home Assistant starts without network connectivity. Changes: - Mark network errors in sign_in() as retriable - Mark network errors in refresh_token() as retriable - This allows consuming code (e.g. Home Assistant integration) to distinguish between transient network failures and actual auth failures The retriable flag is set via the existing Nwp500Error.retriable attribute which was designed for this exact purpose. Fixes: Network errors during startup cause false reauth requests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the authentication module by distinguishing between transient network failures and permanent authentication failures. When network errors occur during sign-in or token refresh operations, they are now marked as retriable, allowing consuming code (like the Home Assistant integration) to avoid triggering unnecessary re-authentication prompts when the network is temporarily unavailable.
Changes:
- Mark
aiohttp.ClientErrorexceptions as retriable insign_in()method - Mark
aiohttp.ClientErrorexceptions as retriable inrefresh_token()method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where network errors during authentication were being treated the same as invalid credentials, causing unnecessary reauth prompts when Home Assistant starts without network connectivity.
Changes:
The retriable flag is set via the existing Nwp500Error.retriable attribute which was designed for this exact purpose.
Fixes: Network errors during startup cause false reauth requests