Skip to content

Mark network errors as retriable in authentication methods #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eman merged 1 commit into from
Jan 16, 2026
Merged

Mark network errors as retriable in authentication methods #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/nwp500/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,10 @@ async def sign_in(

except aiohttp.ClientError as e:
_logger.error(f"Network error during sign-in: {e}")
raise AuthenticationError(f"Network error: {str(e)}") from e
raise AuthenticationError(
f"Network error: {str(e)}",
retriable=True,
) from e
except (KeyError, ValueError, json.JSONDecodeError) as e:
_logger.error(f"Failed to parse authentication response: {e}")
raise AuthenticationError(
Expand Down Expand Up @@ -545,7 +548,10 @@ async def refresh_token(

except aiohttp.ClientError as e:
_logger.error(f"Network error during token refresh: {e}")
raise TokenRefreshError(f"Network error: {str(e)}") from e
raise TokenRefreshError(
f"Network error: {str(e)}",
retriable=True,
) from e
except (KeyError, ValueError, json.JSONDecodeError) as e:
_logger.error(f"Failed to parse refresh response: {e}")
raise TokenRefreshError(f"Invalid response format: {str(e)}") from e
Expand Down