Use require.resolve instead of hardcoded dist path in patches#21265
Merged
NullVoxPopuli merged 1 commit intoemberjs:nvp/v7-testfrom Mar 29, 2026
Merged
Conversation
Replace hardcoded `dist/dev/packages/ember-template-compiler/index.js`
with `require.resolve('ember-source/ember-template-compiler/index.js')`
which resolves through the package exports map, making the patches
resilient to dist layout changes.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6d6b905 to
a0a3759
Compare
Draft
NullVoxPopuli
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded
dist/dev/packages/ember-template-compiler/index.jspath in the ember-cli-htmlbars and ember-auto-import patches withrequire.resolve('ember-source/ember-template-compiler/index.js'), which resolves through the package exports map.This makes the patches resilient to dist layout changes.
Test plan
🤖 Generated with Claude Code