Draft
Conversation
Contributor
📊 Package size report -70.3%↓
🤖 This report was automatically generated by pkg-size-action |
NullVoxPopuli
force-pushed
the
nvp/v7-test
branch
from
2967f47 to
2d1f94f
Compare
NullVoxPopuli
force-pushed
the
nvp/v7-test
branch
6 times, most recently
from
39221bc to
eb0a25f
Compare
This was referenced Mar 28, 2026
NullVoxPopuli
force-pushed
the
nvp/v7-test
branch
from
31b3de0 to
95b7797
Compare
Patches ember-cli@6.11.0 (ember-cli/ember-cli#10971) and @embroider/compat@4.1.16 (embroider-build/embroider#2695) to handle ember-source no longer exporting `paths` in v7. - ember-cli: guard `_initVendorFiles` against missing `paths` - @embroider/compat: skip legacy vendor file creation when `paths` absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Patch ember-cli-htmlbars@7.0.0 to handle missing absolutePaths in v7 ember-source, falling back to the ESM template compiler path. - Update sourcemap-test.js for v7's ESM-only dist structure (dist/ember.debug.js no longer exists). - Include template-compiler-test.js fix for ESM imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The v7 build outputs to dist/dev/packages/ and dist/prod/packages/, not dist/packages/. The template compiler fallback path must use the dev directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ember-auto-import also accesses emberSource.absolutePaths.templateCompiler for babel template compilation config. Add the same fallback to the dist/dev/ ESM template compiler path for v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
force-pushed
the
nvp/v7-test
branch
from
95b7797 to
1e38422
Compare
Replace hardcoded `dist/dev/packages/ember-template-compiler/index.js`
with `require.resolve('ember-source/ember-template-compiler/index.js')`
which resolves through the package exports map, making the patches
resilient to dist layout changes.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 29, 2026
Upstream PRs needed for v7 compatibilityThe following ecosystem packages access
All four are patched via pnpm in #21262 (merged). Once the upstream PRs are released, the patches can be removed. Additionally, #21265 improves those patches to use |
…olve Use require.resolve instead of hardcoded dist path in patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges of:
Needs: