Handle missing absolutePaths for ember-source v7+#708
Merged
NullVoxPopuli merged 2 commits intoembroider-build:mainfrom Mar 29, 2026
Merged
Conversation
Merged
NullVoxPopuli-ai-agent
force-pushed
the
handle-missing-absolutePaths
branch
6 times, most recently
from
6d70335 to
5059609
Compare
The patch targeted the legacy AMD bundles (dist/ember.debug.js, dist/ember.prod.js) which are being removed in ember-source v7. The underlying issue (associateDestroyableChild) was fixed in ember-source itself. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
ember-source v7 no longer exports `absolutePaths` from its addon entry point. Fall back to resolving the template compiler through the package exports map when `absolutePaths` is absent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
handle-missing-absolutePaths
branch
from
5059609 to
c961d74
Compare
kategengler
approved these changes
Mar 29, 2026
Merged
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 29, 2026
…ider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 29, 2026
…ider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 29, 2026
…ider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 29, 2026
…ider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
added a commit
to emberjs/ember.js
that referenced
this pull request
Mar 29, 2026
…ider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
added a commit
to emberjs/ember.js
that referenced
this pull request
Mar 29, 2026
Add pnpm patches for ember-cli and @embroider/compat paths fix Patches ember-cli@6.11.0 (ember-cli/ember-cli#10971) and @embroider/compat@4.1.16 (embroider-build/embroider#2695) to handle ember-source no longer exporting `paths` in v7. - ember-cli: guard `_initVendorFiles` against missing `paths` - @embroider/compat: skip legacy vendor file creation when `paths` absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Add ember-cli-htmlbars patch, fix sourcemap test - Patch ember-cli-htmlbars@7.0.0 to handle missing absolutePaths in v7 ember-source, falling back to the ESM template compiler path. - Update sourcemap-test.js for v7's ESM-only dist structure (dist/ember.debug.js no longer exists). - Include template-compiler-test.js fix for ESM imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Fix ember-cli-htmlbars patch: use dist/dev/ path for v7 The v7 build outputs to dist/dev/packages/ and dist/prod/packages/, not dist/packages/. The template compiler fallback path must use the dev directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Patch ember-auto-import to handle missing absolutePaths ember-auto-import also accesses emberSource.absolutePaths.templateCompiler for babel template compilation config. Add the same fallback to the dist/dev/ ESM template compiler path for v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Use require.resolve instead of hardcoded dist path in patches Replace hardcoded `dist/dev/packages/ember-template-compiler/index.js` with `require.resolve('ember-source/ember-template-compiler/index.js')` which resolves through the package exports map, making the patches resilient to dist layout changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Remove pnpm patches for ember-cli-htmlbars, ember-auto-import, @embroider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
added a commit
to emberjs/ember.js
that referenced
this pull request
Mar 29, 2026
Add pnpm patches for ember-cli and @embroider/compat paths fix Patches ember-cli@6.11.0 (ember-cli/ember-cli#10971) and @embroider/compat@4.1.16 (embroider-build/embroider#2695) to handle ember-source no longer exporting `paths` in v7. - ember-cli: guard `_initVendorFiles` against missing `paths` - @embroider/compat: skip legacy vendor file creation when `paths` absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Add ember-cli-htmlbars patch, fix sourcemap test - Patch ember-cli-htmlbars@7.0.0 to handle missing absolutePaths in v7 ember-source, falling back to the ESM template compiler path. - Update sourcemap-test.js for v7's ESM-only dist structure (dist/ember.debug.js no longer exists). - Include template-compiler-test.js fix for ESM imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Fix ember-cli-htmlbars patch: use dist/dev/ path for v7 The v7 build outputs to dist/dev/packages/ and dist/prod/packages/, not dist/packages/. The template compiler fallback path must use the dev directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Patch ember-auto-import to handle missing absolutePaths ember-auto-import also accesses emberSource.absolutePaths.templateCompiler for babel template compilation config. Add the same fallback to the dist/dev/ ESM template compiler path for v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Use require.resolve instead of hardcoded dist path in patches Replace hardcoded `dist/dev/packages/ember-template-compiler/index.js` with `require.resolve('ember-source/ember-template-compiler/index.js')` which resolves through the package exports map, making the patches resilient to dist layout changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Remove pnpm patches for ember-cli-htmlbars, ember-auto-import, @embroider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-source v7 no longer exports
absolutePathsfrom its addon entry point. This causes a crash incleanBabelConfig()when building classic apps with v7.Fix: Check if
absolutePathsexists before accessing it, and fall back to resolving the template compiler through the package exports map (require.resolve('ember-source/ember-template-compiler/index.js')).Context: emberjs/ember.js#21240
Test plan
absolutePathsas before)require.resolvefallback)🤖 Generated with Claude Code