Fix max_value calculation in permutation_symmetries strategy#688
Closed
Copilot wants to merge 2 commits intofeature/invariance_augmentationfrom
Closed
Fix max_value calculation in permutation_symmetries strategy#688Copilot wants to merge 2 commits intofeature/invariance_augmentationfrom
Copilot wants to merge 2 commits intofeature/invariance_augmentationfrom
Conversation
|
|
Co-authored-by: Scienfitz <17951239+Scienfitz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix calculation for max_value in symmetry and data augmentation
Fix max_value calculation in permutation_symmetries strategy
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #626 (comment)
The
max_valueparameter in thepermutation_symmetrieshypothesis strategy had a copy-paste error:len(parameter_names_pool) // len(parameter_names_pool)always evaluates to 1.Changes
len(parameter_names_pool) // n_params - 1intests/hypothesis_strategies/symmetries.py:55This correctly computes the maximum number of copermuted groups that can fit in the parameter pool without exceeding available parameters.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.