fix(frontend): resolve set-state-in-effect in CommandPalette (#1063)#1076
Open
ericsocrat wants to merge 1 commit intomainfrom
Open
fix(frontend): resolve set-state-in-effect in CommandPalette (#1063)#1076ericsocrat wants to merge 1 commit intomainfrom
ericsocrat wants to merge 1 commit intomainfrom
Conversation
Two violations resolved by adjusting state during render instead of inside useEffect: 1. Reset query/activeIndex on open transition - prevOpen tracker; the imperative <dialog> showModal/close/focus stays in a separate effect (DOM-only, no setState). 2. Keep activeIndex in bounds on filteredItems.length change - prevFilteredLen tracker, clamp during render. Behaviour unchanged. 16/16 tests pass, eslint and tsc clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the CommandPalette component to eliminate react-hooks/set-state-in-effect warnings by moving two pieces of state synchronization (reset-on-open and activeIndex clamping) from useEffect into render-phase state adjustments, while keeping imperative <dialog> DOM operations in an effect.
Changes:
- Reset
queryandactiveIndexon the closed→open transition via aprevOpenrender-phase tracker. - Clamp
activeIndexwhenfilteredItems.lengthshrinks via aprevFilteredLenrender-phase tracker. - Keep
<dialog>showModal/closeand focus behavior in a DOM-onlyuseEffect.
Bundle Size Report
✅ Bundle size is within acceptable limits. |
ericsocrat
added a commit
that referenced
this pull request
May 1, 2026
…) (#1077) Phase 2 of #1063 -- resolves 2 of 19 violations (running total: 12/19 across 9 PRs). Two react-hooks/set-state-in-effect warnings in SearchAutocomplete.tsx resolved by adjusting state during render: 1. Refresh recent-searches list on dropdown open: replaced the show-dep useEffect with a prevShow render-phase tracker. Added a lazy initial-state initializer so the list is hydrated on mount when show is already true (preserves existing test contract). 2. Reset activeIndex when suggestions/query change: replaced the multi-dep useEffect with a composite resetKey + prevResetKey render-phase tracker. Pattern: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean. Cross-references: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076. Co-authored-by: ericsocrat <ericsocrat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of #1063 — eighth PR, resolves 9 + 10 of 19 violations.
Two
react-hooks/set-state-in-effectwarnings inCommandPalette.tsxresolved by adjusting state during render instead of insideuseEffect:prevOpenrender-phase tracker. The imperative<dialog>showModal/close/focus stays in a separate effect (DOM-only, no setState).prevFilteredLenrender-phase tracker; clamp during render whenfilteredItems.lengthshrinks.Pattern reference: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes
Behaviour unchanged. 16/16 vitest pass, eslint and tsc clean.
Cross-references prior Phase 2 PRs: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075.