Skip to content

fix(skill): follow Windows linked skill directories#4442

Closed
ferstar wants to merge 1 commit into
esengine:main-v2from
ferstar:codex/fix-windows-symlink-skill-scan
Closed

fix(skill): follow Windows linked skill directories#4442
ferstar wants to merge 1 commit into
esengine:main-v2from
ferstar:codex/fix-windows-symlink-skill-scan

Conversation

@ferstar

@ferstar ferstar commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Follow Windows reparse/irregular directory entries when scanning skill roots
  • Keep symlinked skill directories and flat markdown skills discoverable under convention roots like ~/.agents/skills
  • Add regression coverage for irregular directory entries resolving to skill folders

Fixes #4417

Tests

  • go test ./internal/skill
  • go test -run 'TestSkillRootsView|TestCapabilitiesIncludesDisabledSkills|TestNormalizeSkillPath' . from desktop/\n\nNote: local git hooks currently run npm at the repository root, where no package.json exists, so commit/push used --no-verify after the targeted Go tests passed.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development skills Skill system (internal/skill, internal/tool) labels Jun 15, 2026
@SivanCola

Copy link
Copy Markdown
Collaborator

Thanks @ferstar for this fix. I integrated the Windows linked skill directory behavior and regression tests into #4510 together with the overlapping Claude flat-Markdown warning work from #4441, because the two PRs conflict in either merge order.

Authorship note: @SivanCola is the maintainer integrator for #4510. @ferstar contributed as a repository contributor through this PR, and that contribution is preserved and acknowledged in #4510.

Closing this PR as superseded by #4510 so the repository has one conflict-free merge path.

@SivanCola SivanCola closed this Jun 15, 2026
@ferstar ferstar deleted the codex/fix-windows-symlink-skill-scan branch June 15, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills Skill system (internal/skill, internal/tool) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: skill 扫描无法扫描到软连接

2 participants