Integrate skill discovery fixes / 集成技能发现修复#4510
Conversation
|
Contribution note: thanks @thomasvan and @ferstar for the overlapping skill-discovery work in #4441 and #4442. This integration PR preserves @thomasvan's Claude flat-Markdown warning fix and tests, and @ferstar's Windows linked skill directory fix and tests. @SivanCola is acting as maintainer integrator here; @thomasvan and @ferstar are acknowledged as repository contributors to this shared fix. |
|
@codex review |
e4785ef to
f3742f1
Compare
|
Status update: the refreshed clean head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4785ef5a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
.claude/skills, so ordinary Claude docs are ignored without warnings.internal/skillchanges from Fix Claude skill markdown warnings #4441 and fix(skill): follow Windows linked skill directories #4442 on currentmain-v2so they can merge without one PR blocking the other.Fixes #4417.
Related PRs
Authorship note: @SivanCola is the maintainer integrator for this PR. @thomasvan and @ferstar contributed as repository collaborators through #4441 and #4442; their work is acknowledged as part of the shared skill-discovery fix.
Cache impact
.claude/skillsflat Markdown and more complete for linked skill directories.Verification
go test ./internal/skill ./internal/configgo test ./internal/bootwith isolatedHOMEandXDG_CONFIG_HOMEgo test -run 'TestSkillRootsView|TestCapabilitiesIncludesDisabledSkills|TestNormalizeSkillPath' .fromdesktop/git diff --checkgo test ./...was also attempted with isolatedHOMEandXDG_CONFIG_HOME; only sandbox confinement tests failed because this local runner does not enforce the expected sandbox denial behavior.