refactor(test-benchmark): port benchmark from bal-devnet-7 - #2977
Merged
spencer-tb merged 8 commits intoJun 12, 2026
Merged
Conversation
…hmark (ethereum#2771) * refactor: failing 8037 benchmark cases * refactor: auth tx limit * fix: linitng issue * chore: ignore local EIP-8037 notes in `markdownlint-cli2` Add `.markdownlint-cli2.yaml` with an `ignores` list for the `EIP8037_REMAINING_FAILURES.md`, `EIP8037_PORTED_STATIC_FAILURES.md`, and `EIP8037_IMPLEMENTATION.md` working notes at the repo root. * refactor: deploy contract gas limit accounting * fix: gas accounting * feat: add stub for new snapshot --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2977 +/- ##
================================================
Coverage 90.53% 90.53%
================================================
Files 535 535
Lines 32893 32893
Branches 3021 3021
================================================
Hits 29780 29780
Misses 2595 2595
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks
Contributor
Author
|
Successful payload generation: https://github.com/NethermindEth/gas-benchmarks/actions/runs/27333143581/job/80750361056 |
spencer-tb
self-requested a review
June 11, 2026 13:10
spencer-tb
approved these changes
Jun 12, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Will consider a small follow up PR for some nits
LouisTsai-Csie
added a commit
that referenced
this pull request
Jun 19, 2026
Co-authored-by: CPerezz <37264926+CPerezz@users.noreply.github.com> Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is the branch for porting the devnet-7/devnet-3 benchmark improvements from
devnet-7-bench(#2885) back toforks/amsterdam.Details of each commit:
NO_CACHEvariant, this commit removes all the other combinations.0x111...111as initial pkey, but it is already occupied, update it to use a more random seed. Related PR feat: add extra withdrawal request for pre-funding NethermindEth/gas-benchmarks#146 could be found in gas-benchmarks.test_sstore_bloatedbenchmark to support eip-8037 state gas calculation.devnet-7-bench(missingCallableimport introduced by the eip-8037SSTOREbenchmark refactor).SSTOREbenchmark refactor relies onfork.sstore_state_gas(), which only exists ondevnet-7-benchand was inlined upstream. Replace it with the existing metadata-drivenloop.state_cost(fork), which also removes the hand-coded(not existing_slots and write_new_value)condition since the SSTORE metadata already encodes the zero-to-nonzero state gas charge.Commit c339b3b, 89c043d and 3eb3acd are already reviewed and merged into
devnets/bal/3(originally as 765f607, 3c11409 and 8a911bb). This PR cherry-picks them to make sure benchmark test implementation is up-to-date to the latest spec.Note: commit 15ee1b1 from
devnet-7-benchis NOT cherry-picked here, since it fixes lint in spec/blockchain code unrelated to the benchmark tests and does not apply to this branch.🔗 Related Issues or PRs
issue #2807
supersedes PR #2885
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture